-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery of screens to the daily spending case study page #279
Conversation
8e89d04 For the context, it's related to this particular part of the page, and here's how it currently looks. @GBKS Thoughts on making these visuals consistent. I really like when it's slightly colored as in the onboarding page, or is the goal for this to be more of a wireframe/mock |
@pavlenex so @danielnordh created this prototype specifically in this wireframe style. Sometimes you don't want people to focus on design details, but on the overall flow, and this is a good method to get that effect. We could have a group discussion to see what the consensus is, but I think that's beyond this PR. |
Agree, separate discussion. Let's not hold up this PR. |
@danielnordh I copy/pasted the description text of each screen in that the image gallery. Some of them got a bit long. Would you want to revise the copy (and other copy one the page)? If so, this PR or a new one? What do you think of the header? |
ping @danielnordh ^ |
The header ads some visual interest. It loaded slowly for me, not sure it's that heavy. |
@danielnordh agreed. I'll remove the header from this one and split it out into a second PR that we can iterate on. Not convinced that the header I proposed here is that great. |
Focusing this PR only on adding the prototype screens to the page.
For a review, would be fantastic to get eyes on the captions of the newly added prototype screens. They are straight from Figma and I find them very long. |
They were just too long.
Tightened up the caption copy. Good to go from my side. Text review would be great. |
All the caption texts now look good to me.
|
@danielnordh good points. I don't like "Design details" either. Better if that carousel has a specific purpose that captures the core experience of the prototype. For example, we could call it "Onboarding sequence", only include those first screens, and add a very short summary in between the header and the carousel. The Figma link can then be the place to see all the screens in the prototype. |
First carousel focuses on the automatic cloud backup experience, the second one on wallet import. Removed several miscellaneous screens from the carousel (like settings), as there wasn't a clear design story to tell.
@danielnordh I split up the carousel in two, focusing the first one on the onboarding experience via automatic cloud backup, and the second one on importing a wallet. They have more specific titles and descriptions. Check it. Looks like we're going to get a little bit of overlap between this page and the upcoming onboarding pages (here and here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, makes the page more valuable without having to visit the Figma file.
Looks good to go.
Adds an image gallery of the screens in the prototype so they can be more easily analyzed.