Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery of screens to the daily spending case study page #279

Merged
merged 10 commits into from
May 14, 2021

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented May 4, 2021

Adds an image gallery of the screens in the prototype so they can be more easily analyzed.

@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. labels May 4, 2021
@GBKS GBKS self-assigned this May 4, 2021
@pavlenex
Copy link
Contributor

pavlenex commented May 4, 2021

8e89d04
I like it. Really makes the page pop.

For the context, it's related to this particular part of the page, and here's how it currently looks.

Screenshot 2021-05-04 at 18 31 42

@GBKS Thoughts on making these visuals consistent. I really like when it's slightly colored as in the onboarding page, or is the goal for this to be more of a wireframe/mock

@GBKS
Copy link
Contributor Author

GBKS commented May 5, 2021

@pavlenex so @danielnordh created this prototype specifically in this wireframe style. Sometimes you don't want people to focus on design details, but on the overall flow, and this is a good method to get that effect. We could have a group discussion to see what the consensus is, but I think that's beyond this PR.

@danielnordh
Copy link
Contributor

Agree, separate discussion. Let's not hold up this PR.
(I have started playing with using the UI Kit for these case studies, but that is on a different track)

@GBKS
Copy link
Contributor Author

GBKS commented May 5, 2021

@danielnordh I copy/pasted the description text of each screen in that the image gallery. Some of them got a bit long. Would you want to revise the copy (and other copy one the page)? If so, this PR or a new one? What do you think of the header?

@pavlenex
Copy link
Contributor

pavlenex commented May 7, 2021

ping @danielnordh ^
@GBKS LGTM, ready for review?

@danielnordh
Copy link
Contributor

The header ads some visual interest. It loaded slowly for me, not sure it's that heavy.
My only thought is that if we add a header on this page, the other case study pages feel quite different.
I would try to add them all in this PR, or make headers separate from the other changes.

@GBKS
Copy link
Contributor Author

GBKS commented May 10, 2021

@danielnordh agreed. I'll remove the header from this one and split it out into a second PR that we can iterate on. Not convinced that the header I proposed here is that great.

Focusing this PR only on adding the prototype screens to the page.
@GBKS GBKS marked this pull request as ready for review May 10, 2021 06:22
@GBKS
Copy link
Contributor Author

GBKS commented May 10, 2021

For a review, would be fantastic to get eyes on the captions of the newly added prototype screens. They are straight from Figma and I find them very long.

@GBKS GBKS changed the title Added header and screen mockups to cloud backup page Added gallery of screens to the daily spending case study page May 11, 2021
@GBKS GBKS changed the title Added gallery of screens to the daily spending case study page Add gallery of screens to the daily spending case study page May 11, 2021
@GBKS
Copy link
Contributor Author

GBKS commented May 11, 2021

Tightened up the caption copy. Good to go from my side. Text review would be great.

@GBKS GBKS requested a review from danielnordh May 11, 2021 11:09
@danielnordh
Copy link
Contributor

All the caption texts now look good to me.
Some thoughts, that don't necessarily need changes:

  • Should the header before the carousel change from 'Design details' to 'Screen wireframes' / 'Wireframe mockups' to make it uber clear these are not detailed designs
  • The carousel kind of reads as a continuous flow, which is (almost) true for the first few screens but then not. Not sure how to improve this, and it's a minor point

@GBKS
Copy link
Contributor Author

GBKS commented May 11, 2021

@danielnordh good points. I don't like "Design details" either. Better if that carousel has a specific purpose that captures the core experience of the prototype. For example, we could call it "Onboarding sequence", only include those first screens, and add a very short summary in between the header and the carousel. The Figma link can then be the place to see all the screens in the prototype.

GBKS added 2 commits May 14, 2021 10:31
First carousel focuses on the automatic cloud backup experience, the second one on wallet import.

Removed several miscellaneous screens from the carousel (like settings), as there wasn't a clear design story to tell.
@GBKS
Copy link
Contributor Author

GBKS commented May 14, 2021

@danielnordh I split up the carousel in two, focusing the first one on the onboarding experience via automatic cloud backup, and the second one on importing a wallet. They have more specific titles and descriptions. Check it.

Looks like we're going to get a little bit of overlap between this page and the upcoming onboarding pages (here and here).

Copy link
Contributor

@danielnordh danielnordh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, makes the page more valuable without having to visit the Figma file.
Looks good to go.

@GBKS GBKS merged commit d39ba22 into master May 14, 2021
@danielnordh danielnordh deleted the feature/cloud-backup-case-study-visuals branch September 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy Task is about improving text. Design Task is about designing something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants