Skip to content

Add gallery of screens to the multisig case study page #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2021

Conversation

GBKS
Copy link
Contributor

@GBKS GBKS commented May 11, 2021

Adds an image gallery of the screens in the prototype so they can be more easily analyzed.

@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. labels May 11, 2021
@GBKS GBKS self-assigned this May 11, 2021
@Bosch-0
Copy link
Collaborator

Bosch-0 commented May 11, 2021

I actually prefer having this over the prototype. Although the prototype gives that extra depth compared to static images I'd rather view them then go to an external link.

Also this page is called 'checking account' in the menu but the page is called multisig-wallet - maybe we should update this. Made an issue #307 for this / as well as changing from 'checkings' to 'savings' account.

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GBKS GBKS merged commit 9cd5bc5 into master May 12, 2021
@danielnordh danielnordh deleted the feature/multisig-case-study-image-gallery branch September 17, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy Task is about improving text. Design Task is about designing something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants