Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ⚡️ content to Getting Started > Visual language #475

Merged
merged 16 commits into from
Sep 20, 2021
Merged

Added ⚡️ content to Getting Started > Visual language #475

merged 16 commits into from
Sep 20, 2021

Conversation

sbddesign
Copy link
Collaborator

@sbddesign sbddesign commented Sep 15, 2021 •
edited
Loading

I added LN content to Getting Started > Visual Language for #464.

See Deploy Preview

Bosch-0
Bosch-0 reviewed Sep 16, 2021
View reviewed changes
guide/getting-started/visual-language.md Outdated
@@ -39,6 +39,7 @@ layout = "full-width"

Since Bitcoin answers to no central authority, there is no single symbol or logo that can visually represent it, though many try. Here are some of the most recognized attempts to create a universal logo for Bitcoin.

## The Bitcoin symbol

### Original symbol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the date the core client was launched with this symbol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know this date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling this 'The Bitcoin' symbol is not helping IMO. It's a gold coin with 'BC' in the middle.
When people say the Bitcoin symbol today, they mostly refer to the Bitboy update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielnordh I added this heading because I don't like the page jumping from an H1 to an H3 heading. Let me see what I can do to amend this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended in d8b2932
@Bosch-0 I added a tidbit about the launch date
@danielnordh I removed "The Bitcoin symbol" and adjusted the heading levels.
How does that look?

Bosch-0
Bosch-0 reviewed Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@Bosch-0 Bosch-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@GBKS GBKS added the Copy Task is about improving text. label Sep 16, 2021
@GBKS GBKS added this to the Milestone #7 milestone Sep 16, 2021
@GBKS
Copy link
Contributor

GBKS commented Sep 16, 2021

Bob had a request in Slack to add links to the Bitcoin and Lightning logos to this page, presumably for people to download them quickly for their projects.

pavlenex
pavlenex reviewed Sep 16, 2021
View reviewed changes
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sbddesign, I have a couple of minor suggestions and one question listed below.

guide/getting-started/visual-language.md Show resolved Hide resolved
guide/getting-started/visual-language.md Outdated Show resolved Hide resolved
guide/getting-started/visual-language.md Outdated Show resolved Hide resolved
guide/getting-started/visual-language.md Outdated Show resolved Hide resolved
@sbddesign
Copy link
Collaborator Author

Bob had a request in Slack to add links to the Bitcoin and Lightning logos to this page, presumably for people to download them quickly for their projects.

I like the idea of providing a quick, easy way to download some basic Bitcoin branding assets.

I am a little skeptical about the idea of providing a Lightning symbol for download, for two reasons.

A) I do not think that there is the same consensus about the Lightning logo that there is with the Bitcoin logo. For example, I also frequently see the purple version of the bolt.

B) If our goal is to de-emphasize Lightning as feeling separate from Bitcoin, offering up a Lightning logo for download might go against that goal.

@GBKS GBKS linked an issue Sep 17, 2021 that may be closed by this pull request
Add ⚡️ content to Getting Started > Visual Language #464
Closed
@GBKS
Copy link
Contributor

GBKS commented Sep 17, 2021

@sbddesign I agree with your rationale. Another option is to link to https://bitcoinicons.com, which includes both icons, along with many others.

@danielnordh danielnordh mentioned this pull request Sep 17, 2021
Closed
46 tasks
@danielnordh
Copy link
Contributor

Bob had a request in Slack to add links to the Bitcoin and Lightning logos to this page, presumably for people to download them quickly for their projects.

I think it would be valuable to have the Bitcoin symbol as easily downloadable resources. Could link to other places where it's available, OR try to over time have the guide be the top result for 'bitcoin logo' 'bitcoin symbol' on Google.

I'm less sure on the Lightning situation, I'd say let's hold off on settling on ONE version.

@sbddesign
Copy link
Collaborator Author

I updated with a button to download the Bitcoin symbol in SVG and PNG

GBKS
GBKS requested changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update. Just had a few minor nitpicks and then let's merge.

@GBKS GBKS changed the title Lightning content for Getting Started > Visual Language Add ⚡️ content to Getting Started > Why bitcoin is unique Sep 20, 2021
@GBKS GBKS changed the title Add ⚡️ content to Getting Started > Why bitcoin is unique Add ⚡️ content to Getting Started > Visual language Sep 20, 2021
@GBKS GBKS changed the title Add ⚡️ content to Getting Started > Visual language Added ⚡️ content to Getting Started > Visual language Sep 20, 2021
Stephen DeLorme and others added 5 commits September 20, 2021 05:37
@GBKS
Switch to relative links
23b0877 
Co-authored-by: Christoph Ono <chri@sto.ph>
@GBKS
Updated image size
056fb84 
Co-authored-by: Christoph Ono <chri@sto.ph>
@GBKS
Updated satoshis image size
16dc701 
Co-authored-by: Christoph Ono <chri@sto.ph>
@sbddesign
Fixed image 2-col layout
705f1fd
@sbddesign
Adding download attribute and relative link handler to logo links
fb217e9
@sbddesign sbddesign requested a review from GBKS September 20, 2021 10:09
GBKS
GBKS approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, thanks for also squeezing Sats in this one, it had been such a long lingering task.

@GBKS GBKS merged commit e4e229b into BitcoinDesign:master Sep 20, 2021
@GBKS GBKS mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bosch-0 Bosch-0 Bosch-0 left review comments

@pavlenex pavlenex pavlenex left review comments

@danielnordh danielnordh danielnordh left review comments

@GBKS GBKS GBKS approved these changes

Assignees

@sbddesign sbddesign

Labels
Copy Task is about improving text.
Projects
None yet
Milestone
Milestone #7
Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Getting Started > Visual Language
5 participants
@sbddesign @GBKS @danielnordh @pavlenex @Bosch-0