Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Units and Symbols Page #63
Add a Units and Symbols Page #63
Changes from all commits
373e828
7a2eb62
cf53f0d
d6381ed
3980e3d
9587678
1c104c3
4894a09
4b04d73
cef17ae
ff05aaa
997db24
1a44d54
e32b5bb
e203670
557b1ef
1cb82fc
787319c
84e5e6a
fb45084
f42d700
8c418e0
1ca97e1
3000e51
29d6a32
5209bfb
89331c6
fdf15d1
efc4318
cf613d8
1533969
307923a
747d8f8
3745f25
0531014
a7f5b36
fe50535
3a77f7b
48885ff
23e3152
1bd888a
7307996
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contrast in the alternate coloring isn't clear, I couldn't see the difference at a first glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I went back and forth on that. Too strong of a contrast results makes the numbers hard to read, and too little contrast is barely noticeable. I went for low contrast after experimenting a bit, as it's meant to be a subtle helper and work almost subconsciously. I think designers need to adjust this based on the foreground/background colors they use, as well as font details (thin vs. bold).