Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port multiple master-targeted fixes to janus release branch #56

Closed
wants to merge 32 commits into from
Closed

Port multiple master-targeted fixes to janus release branch #56

wants to merge 32 commits into from

Commits on Sep 1, 2021

  1. correct python3 comparison operator

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    4287126 View commit details
    Browse the repository at this point in the history

  2. enable building tests by default, external signer default to match bi… 

    …tcoin core, and turn off warning silencing for implicit fallthrough
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    82be88a View commit details
    Browse the repository at this point in the history

  3. reinstate valid base58 test data and test methodology from bitcoin core 

    # Conflicts:
#	src/test/data/base58_encode_decode.json
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    dc7c5ae View commit details
    Browse the repository at this point in the history

  4. declare classes final where appropriate, to enable devirtualisation o… 

    …f calls, and add placeholder warning to suggest possible final types
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    5bcd84e View commit details
    Browse the repository at this point in the history

  5. add warning to suggest attribute noreturn if applicable 

    # Conflicts:
#	configure.ac
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    d9d0c9a View commit details
    Browse the repository at this point in the history

  6. add warning to suggest attribute const and placeholder warning for at… 

    …tribute pure
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    cadbc14 View commit details
    Browse the repository at this point in the history

  7. add single warning for "unused" warning options

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    7413615 View commit details
    Browse the repository at this point in the history

  8. add attribute [[maybe_unused]] to mark parameters that are known not … 

    …to be used, and re-enable unused parameter warning to identify unintentionally unused parameters in future
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    bcc5729 View commit details
    Browse the repository at this point in the history

  9. remove unused debugging includes

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    74e3558 View commit details
    Browse the repository at this point in the history

  10. use C++17 fallthrough attributes instead of comments, resolve fallthr… 

    …ough warning
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    602e578 View commit details
    Browse the repository at this point in the history

  11. add modern fallthrough attribute, replace old hacky solutions

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    53702ef View commit details
    Browse the repository at this point in the history

  12. tidy and remove unneeded braces for cases that don't require them

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    1153e5f View commit details
    Browse the repository at this point in the history

  13. add warning for non-virtual destructor in base class, and fix all ins… 

    …tances
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    bb7b45a View commit details
    Browse the repository at this point in the history

  14. add extra performance and safety compiler warnings

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    b302246 View commit details
    Browse the repository at this point in the history

  15. add warning for implicit double promotion

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    8fc8b6e View commit details
    Browse the repository at this point in the history

  16. avoid unnecessary double promotion in calculating time interval, and … 

    …replace C cast with static_cast
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    fe178e9 View commit details
    Browse the repository at this point in the history

  17. avoid implicit conversions that may alter a value, or make them expli… 

    …cit where intended
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e5e2f10 View commit details
    Browse the repository at this point in the history

  18. placeholder warnings for conversion and useless casts

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    641b656 View commit details
    Browse the repository at this point in the history

  19. do not enable DEBUG_LOCKORDER for all debug builds; the code associat… 

    …ed with this flag is broken in any case
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    2e9f261 View commit details
    Browse the repository at this point in the history

  20. remove unused includes

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e82c875 View commit details
    Browse the repository at this point in the history

  21. don't disable implicit-fallthrough warning (this is now dealt with in… 

    … another PR)
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    06c8771 View commit details
    Browse the repository at this point in the history

  22. re-enable asserts for signet chain params at creation, with correct g… 

    …enesis block hash and merkle root hash
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    fbc5630 View commit details
    Browse the repository at this point in the history

  23. remove unused include

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    47d9edd View commit details
    Browse the repository at this point in the history

  24. add tests to verify test addresses are valid - this also tests the va… 

    …lidator
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    333e731 View commit details
    Browse the repository at this point in the history

  25. add a test to ensure a BTC address does not count as a valid destination

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    24b4b53 View commit details
    Browse the repository at this point in the history

  26. enable building tests by default, external signer default to match bi… 

    …tcoin core, and turn off warning silencing for implicit fallthrough
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f97a386 View commit details
    Browse the repository at this point in the history

  27. don't disable implicit-fallthrough warning (this is now dealt with in… 

    … another PR)
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    0743fd2 View commit details
    Browse the repository at this point in the history

  28. update benchmark decode address to BGL prefix for consistency

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    5dd71f1 View commit details
    Browse the repository at this point in the history

  29. update test data sample BTC address to BGL format with prefix 10

    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    242d656 View commit details
    Browse the repository at this point in the history

  30. some tests use the pubkey of the BTC genesis block - update these to … 

    …use the correct pubkey of the BGL genesis block instead
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    0d0d37b View commit details
    Browse the repository at this point in the history

  31. Revert "don't disable implicit-fallthrough warning (this is now dealt… 

    … with in another PR)"

This reverts commit 0743fd2.
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c6bb29c View commit details
    Browse the repository at this point in the history

  32. remove attribute final from classes Sock, CCoinsViewCache, Descriptor… 

    …ScriptPubKeyMan to accomodate new fuzzing classes
    @slowriot
    slowriot committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    53de81b View commit details
    Browse the repository at this point in the history