Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verified domains article #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Anna15170221
Copy link
Contributor

The line 51 should contain {DOMAIN}. I don't know how to include the curly braces {}; it causes an error

the line 51 should contain {DOMAIN}, I don't know how to put {}, it causes the error
@ihomp
Copy link
Member

ihomp commented Apr 3, 2025

  • the similar images for all the networks are better to keep in separate folders for each page, like
    /pages/verified-domains/green-checkmark.jpg

if the images are different for different networks, we have folders
xrplexplorer/pages/verified-domains/checkmark.png
xahauexplorer/pages/verified-domains/checkmark.png

where verified-domains should be exactly the same as the route name (which is usually a page address)

The name of the image should describe the image
so instead of /pages/verified-domains-picture.jpg we should have /pages/verified-domains/green-checkmark.jpg

That way we will keep the structure well maintained, and later it will be easier to automate things.

@ihomp ihomp self-requested a review April 3, 2025 16:42
@ihomp
Copy link
Member

ihomp commented Apr 3, 2025

The line 51 should contain {DOMAIN}. I don't know how to include the curly braces {}; it causes an error

Screenshot 2025-04-03 at 18 44 37

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the images names and structure needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants