Skip to content

Conversation

@pandablue0809 pandablue0809 requested a review from ihomp August 20, 2025 08:19
@ihomp
Copy link
Member

ihomp commented Sep 14, 2025

@Anna15170221 please test this one too

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a bit of code optimisation

setStatus(t('form.error.address-empty'))
setFormError(true)
// For regular NFT transfer offers
tx.Amount = '0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is code is exactly the same as for remit, except the amount.. Please don't copy-paste the same code!

if (tx.TransactionType !== 'Remit') {
  tx.Amount = '0'
}

@Anna15170221
Copy link
Contributor

Anna15170221 commented Sep 15, 2025

@ihomp @pandablue0809
seems not working for me
Tx is signed and I got this
Screenshot 2025-09-15 at 13 16 18
NFT was not sent

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it. plz review again. 🙏

@pandablue0809 pandablue0809 requested a review from ihomp September 18, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants