Skip to content

/tokens sorting options improvements needed #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

/tokens sorting options improvements needed #572

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f42eea1
tokens sorting options improvemen
pandablue0809 Aug 25, 2025
b3feb6b
fix price sort
pandablue0809 Aug 26, 2025
227f30b
Merge remote-tracking branch 'upstream/main' into feat/559/tokens-sor…
pandablue0809 Aug 26, 2025
de5570e
fix sync dropdown and arrow
pandablue0809 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 80 additions & 84 deletions pages/tokens.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { serverSideTranslations } from 'next-i18next/serverSideTranslations'
import axios from 'axios'
import { useState, useEffect, useRef } from 'react'
import { FaHandshake } from 'react-icons/fa'
import { FaLongArrowAltDown, FaLongArrowAltUp } from "react-icons/fa";


import SEO from '../components/SEO'
import FiltersFrame from '../components/Layout/FiltersFrame'
Expand Down Expand Up @@ -31,6 +33,35 @@ import {
import { useRouter } from 'next/router'
import { fetchHistoricalRate } from '../utils/common'

// Sorting Arrow Component
const SortingArrow = ({ sortKey, currentSort, onClick, canSortBothWays = false }) => {
const isActive = currentSort.key === sortKey
const isDescending = currentSort.direction === 'descending'

let arrowIcon
let arrowClass = 'link green inline-flex items-center'

if (canSortBothWays) {
arrowIcon = (
<span className="inline-flex items-center">
<FaLongArrowAltUp className={isActive && !isDescending ? 'orange' : ''} />
<FaLongArrowAltDown className={isActive && isDescending ? 'orange ml-[-6px]' : 'ml-[-6px]'} />
</span>
)
} else {
if (isActive) {
arrowClass = 'link orange inline-flex items-center'
}
arrowIcon = <FaLongArrowAltDown />
}

return (
<b className={arrowClass} onClick={onClick}>
{arrowIcon}
</b>
)
}

/*
{
"token": "rL2sSC2eMm6xYyx1nqZ9MW4AP185mg7N9t:4150585800000000000000000000000000000000",
Expand Down Expand Up @@ -82,11 +113,8 @@ export async function getServerSideProps(context) {
const supportedOrders = new Set([
'rating',
'trustlinesHigh',
'trustlinesLow',
'holdersHigh',
'holdersLow',
'priceNativeCurrencyHigh',
'priceNativeCurrencyLow',
'marketCapHigh',
'sellVolumeHigh',
'buyVolumeHigh',
Expand Down Expand Up @@ -147,11 +175,8 @@ export async function getServerSideProps(context) {
const orderList = [
{ value: 'rating', label: 'Rating: High to Low' },
{ value: 'trustlinesHigh', label: 'Trustlines: High to Low' },
{ value: 'trustlinesLow', label: 'Trustlines: Low to High' },
{ value: 'holdersHigh', label: 'Holders: High to Low' },
{ value: 'holdersLow', label: 'Holders: Low to High' },
{ value: 'priceNativeCurrencyHigh', label: 'Price: High to Low' },
{ value: 'priceNativeCurrencyLow', label: 'Price: Low to High' },
{ value: 'marketCapHigh', label: 'Marketcap: High to Low' },
{ value: 'sellVolumeHigh', label: 'Sell Volume (24h): High to Low' },
{ value: 'buyVolumeHigh', label: 'Buy Volume (24h): High to Low' },
Expand Down Expand Up @@ -213,16 +238,10 @@ export default function Tokens({
return { key: 'rating', direction: 'descending' }
case 'trustlinesHigh':
return { key: 'trustlines', direction: 'descending' }
case 'trustlinesLow':
return { key: 'trustlines', direction: 'ascending' }
case 'holdersHigh':
return { key: 'holders', direction: 'descending' }
case 'holdersLow':
return { key: 'holders', direction: 'ascending' }
case 'priceNativeCurrencyHigh':
return { key: 'price', direction: 'descending' }
case 'priceNativeCurrencyLow':
return { key: 'price', direction: 'ascending' }
case 'marketCapHigh':
return { key: 'marketcap', direction: 'descending' }
case 'sellVolumeHigh':
Expand Down Expand Up @@ -327,6 +346,12 @@ export default function Tokens({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [order, issuer, currency, subscriptionExpired])

// Effect: update sortConfig when order changes (e.g., from dropdown)
useEffect(() => {
setSortConfig(getInitialSortConfig(order))
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [order])

useEffect(() => {
let queryAddList = []
let queryRemoveList = []
Expand Down Expand Up @@ -547,26 +572,28 @@ export default function Tokens({

const sortTable = (key) => {
if (!data || data.length === 0) return
let direction = 'descending'
if (sortConfig.key === key && sortConfig.direction === direction) {
direction = 'ascending'

if (sortConfig.key === key) {
setSortConfig({ key: 'rating', direction: 'descending' })
setOrder('rating')
return
}

let direction = 'descending'
setSortConfig({ key, direction })

const apiOrderFor = (k, dir) => {
const isDesc = dir === 'descending'
const apiOrderFor = (k) => {
switch (k) {
case 'rating':
case 'index':
return 'rating'
case 'trustlines':
return isDesc ? 'trustlinesHigh' : 'trustlinesLow'
return 'trustlinesHigh'
case 'holders':
return isDesc ? 'holdersHigh' : 'holdersLow'
return 'holdersHigh'
case 'price':
return isDesc ? 'priceNativeCurrencyHigh' : 'priceNativeCurrencyLow'
return 'priceNativeCurrencyHigh'
case 'marketcap':
// Only High supported per new API list
return 'marketCapHigh'
case 'buyVolume':
return 'buyVolumeHigh'
Expand All @@ -580,14 +607,12 @@ export default function Tokens({
return 'uniqueSellersHigh'
case 'uniqueBuyers':
return 'uniqueBuyersHigh'
case 'token':
return null
default:
return null
}
}

const newApiOrder = apiOrderFor(key, direction)
const newApiOrder = apiOrderFor(key)
if (newApiOrder) {
setOrder(newApiOrder)
}
Expand Down Expand Up @@ -640,72 +665,47 @@ export default function Tokens({
<thead>
<tr>
<th className="center">
<b
className={'link' + (sortConfig.key === 'rating' ? ' orange' : '')}
onClick={() => sortTable('rating')}
>
{' '}
<span className="inline-flex items-center">
#
</b>
<SortingArrow sortKey="rating" currentSort={sortConfig} onClick={() => sortTable('rating')} />
</span>
</th>
<th>Token</th>
<th className="right">
Price
<b
className={'link' + (sortConfig.key === 'price' ? ' orange' : '')}
onClick={() => sortTable('price')}
>
{' '}
⇅
</b>
<span className="inline-flex items-center">
Price
<SortingArrow sortKey="price" currentSort={sortConfig} onClick={() => sortTable('price')} />
</span>
</th>
<th className="right">Change (24h)</th>
<th className="right">
Total volume
<br />
(24h)
<b
className={'link' + (sortConfig.key === 'totalVolume' ? ' orange' : '')}
onClick={() => sortTable('totalVolume')}
>
{' '}
⇅
</b>
<span className="inline-flex items-center">
(24h)
<SortingArrow sortKey="totalVolume" currentSort={sortConfig} onClick={() => sortTable('totalVolume')} />
</span>
</th>
<th className="right">
Buyers{' '}
<b
className={'link' + (sortConfig.key === 'uniqueBuyers' ? ' orange' : '')}
onClick={() => sortTable('uniqueBuyers')}
>
⇅
</b>{' '}
/ Sellers{' '}
<b
className={'link' + (sortConfig.key === 'uniqueSellers' ? ' orange' : '')}
onClick={() => sortTable('uniqueSellers')}
>
⇅
</b>
<span className="inline-flex items-center">
Buyers
<SortingArrow sortKey="uniqueBuyers" currentSort={sortConfig} onClick={() => sortTable('uniqueBuyers')} />
</span>
<span className="inline-flex items-center">
/ Sellers
<SortingArrow sortKey="uniqueSellers" currentSort={sortConfig} onClick={() => sortTable('uniqueSellers')} />
</span>
<br />
Traders (24h)
<b
className={'link' + (sortConfig.key === 'uniqueTraders' ? ' orange' : '')}
onClick={() => sortTable('uniqueTraders')}
>
{' '}
⇅
</b>
<span className="inline-flex items-center">
Traders (24h)
<SortingArrow sortKey="uniqueTraders" currentSort={sortConfig} onClick={() => sortTable('uniqueTraders')} />
</span>
</th>
<th className="right">
Holders{' '}
<b
className={'link' + (sortConfig.key === 'holders' ? ' orange' : '')}
onClick={() => sortTable('holders')}
>
⇅
</b>
,
<span className="inline-flex items-center">
Holders
<SortingArrow sortKey="holders" currentSort={sortConfig} onClick={() => sortTable('holders')} />,
</span>
<br />
Active (24h)
</th>
Expand All @@ -722,14 +722,10 @@ export default function Tokens({
(24h)
</th>
<th className="right">
Marketcap
<b
className={'link' + (sortConfig.key === 'marketcap' ? ' orange' : '')}
onClick={() => sortTable('marketcap')}
>
{' '}
⇅
</b>
<span className="inline-flex items-center">
Marketcap
<SortingArrow sortKey="marketcap" currentSort={sortConfig} onClick={() => sortTable('marketcap')} />
</span>
</th>
<th className="center">Action</th>
</tr>
Expand Down