Fix/517/update filter hide #573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We have a mess with the param const [filtersHide, setFiltersHide]
The problem that those two behaves differently and means the opposite on mobile. On mobile right now filtersHide means filters will be open. We need to fix it, so filtersHide as true should mean that filters are hidden - doesn’t matter if it’s desktop or mobile. For now it was just added a quick hack and set by default the value as !isSsrMobile const [filtersHide, setFiltersHide] = useState(!isSsrMobile) which is ok only on mobiles and destktops - but very messy on other screens - the filters will be open automatically on the page load. so, that param should be fixed.. filtersHide should mean no filters on both mobile and desktop. As it was extracted as a component - we would need to make the changes in all the places where it is in use in the app.