-
Notifications
You must be signed in to change notification settings - Fork 25
paystrings article #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
paystrings article #644
Conversation
pages/learn/paystrings.js
Outdated
| return ( | ||
| <> | ||
| <SEO | ||
| title={'PayStrings on' + explorerName} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not use explorerName in titles. (it is already there.)
title="PayStrings"
pages/learn/paystrings.js
Outdated
| <> | ||
| <SEO | ||
| title={'PayStrings on' + explorerName} | ||
| description="Learn what PayString on XRPL and Xahau is and how to register yours on Bithomp. Send, receive, deposit, and withdraw XRP easily with a simple PayString name." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use "on XRPL and Xahau" - you can remove it
replace XRP with {nativeCurrency} or remove it
pages/learn/paystrings.js
Outdated
| <p> | ||
| Instead of sending {nativeCurrency} to a long address, you can use something like{' '} | ||
| <strong>{xahauNetwork ? 'bob$xahauexplorer.com' : 'bob$bithomp.com'}</strong> or{' '} | ||
| <strong>{xahauNetwork ? 'kingkong@xahauexplorer.com' : 'kingkong@bithomp.com'}</strong>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are they exists? and do they work?
pages/sitemap.xml.js
Outdated
| { loc: 'learn/guide-for-token-issuers', changefreq: 'monthly', priority: '0.9' }, | ||
| { loc: 'learn/image-services', changefreq: 'monthly', priority: '0.6' } | ||
| { loc: 'learn/image-services', changefreq: 'monthly', priority: '0.6' }, | ||
| { loc: 'learn/paystrings', changefreq: 'monthly', priority: '0.7' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.5 should eb enough
|
It seems we have 2 different types for xahau/xrpl images we used to split images to two different folders when they are different
that how it was used in nft-minting page, explorer-advantages, verified-domains Now I see you use I think for the featurw when it will be more networks, not just xahau and xrpl, then it will be easier to maintain, if we well have the similar images in the |
pages/learn/paystrings.js
Outdated
| <figure> | ||
| <Image | ||
| src={'/images/pages/learn/paystrings/cover' + (xahauNetwork ? '-xahau' : '') + '.jpg'} | ||
| alt="Paystrings on XRPL and Xahau" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use "on XRPL and Xahau"
ihomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the comments
No description provided.