Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Update to PyQt5 #897

Open
ghost opened this issue Sep 4, 2016 · 22 comments
Open

[Security] Update to PyQt5 #897

ghost opened this issue Sep 4, 2016 · 22 comments
Assignees
Labels
enhancement New feature
Milestone

Comments

@ghost
Copy link

ghost commented Sep 4, 2016

As you know Qt4 is no longer receiving security updates, you should switch to Qt5 and its python bindings.
The switch from pyqt4 to pyqt5 should be relatively easy according to pyqt documentation on this topic (for example here).

@bmng-dev
Copy link
Contributor

bmng-dev commented Sep 5, 2016

It is not so much PyQt but Qt itself that is the issue. Windows XP is still a supported platform for PyBitmessage. However Windows XP (and Vista) is missing from Qt5's Supported Platforms, although Qt for Windows - Specific Issues indicate it might be possible to build Qt5 for Windows XP. I understand @PeterSurda builds Qt4 as part of the release process so it is up to whether he can successfully build Qt5 and ensure everything still works on Windows XP before switching.

@ghost
Copy link
Author

ghost commented Sep 5, 2016

Qt4 is not maintained by the Qt project, when bugs are discovered, users can and will be hacked through the old Qt. Additionally, Windows XP is no longer LTS of Windows.
This is illogical.

@ghost
Copy link
Author

ghost commented Sep 5, 2016

Documentation / Upstream says it is possible to build Qt5 for XP.

Additional reading sources: https://doc.qt.io/qt-5/supported-platforms-and-configurations.html
"using Qt 5.6, XP will be supported until March 16, 2019"

@ghost
Copy link
Author

ghost commented Nov 25, 2016

Ping on the ticket.

@PeterSurda @bmng-dev do you plan to fix this at all, and if you will fix it what's the targeted version for this?
I also advise you to drop the idea of supporting an outdated, no longer supported, Microsoft system.

@ghost ghost changed the title Qt4 is no longer receiving security updates, it is advised to change to Qt5 and PyQt5. [Security] Update to PyQt5 Nov 25, 2016
@bmng-dev
Copy link
Contributor

Sorry @ghost, it's not up to me. I don't know why @PeterSurda hasn't responded.

@PeterSurda
Copy link
Member

There are no specific plans, there are higher priority things. I'd prefer code that works both with Qt4 and Qt5 if possible, if someone submits a pull request I'll be happy to look at it.

@PeterSurda PeterSurda added the enhancement New feature label Nov 29, 2016
@PeterSurda PeterSurda added this to the Undefined milestone Nov 29, 2016
@Lvl4Sword
Copy link
Contributor

@bmng-dev I'm confused as to why XP/Vista would be supported at all, since those are EOL according to Microsoft ( and thus should be updated/replaced )
I stand by ghost's advice on not standing by these out-of-date systems

@bmng-dev
Copy link
Contributor

@Lvl4Sword you and me both. I'm just someone who is interested in Bitmessage like you. I am not, nor have I ever been, involved in the decision making process of this project. At the time I responded to @ghost I thought Windows XP was supported because of things I had read from @PeterSurda (other issues here on github, on the forums, reddit, or on the bitmessage chan I can't remember) and tried to be helpful with a timely response anticipating what some of @PeterSurda concerns might be about moving to Qt5. The jury is still out on whether I'm correct or not.

@PeterSurda
Copy link
Member

PeterSurda commented Jun 30, 2017

Just to clarify:

  • at the moment, the backwards compatibility with Windows doesn't appear to create extra effort. I build the 32bit binaries on Windows 7, and while I do have a test environment for XP, I don't recall having problems since switching the build environment to Windows 7. Today's devel snapshot also works on Windows XP, even though I haven't done any tests on XP since releasing 0.6.2. I haven't really tested most of the post-0.6.2 changes on anything else than linux for that matter. It's possible that at some stage the backwards compatibility will break, and I'll make a decision at that time.

  • the reason why I haven't switched to PyQt5 is that it's lower priority than other things. I don't know what the differences between Qt4 and Qt5 are and I'm not a UI specialist.

@a17r
Copy link

a17r commented Feb 15, 2018

Please note that Qt4 and PyQt4 support is being dropped in distributions everywhere at this point, since being unmaintained for years.

@PeterSurda
Copy link
Member

Sadly, I'm busy with more urgent issues and I've never used PyQt5 before. Maybe someone else can do that. @g1itch any interest?

@g1itch
Copy link
Collaborator

g1itch commented Feb 15, 2018

Actually I started already. And have first preview.

@PeterSurda
Copy link
Member

Excellent, thank you very much!

@g1itch
Copy link
Collaborator

g1itch commented Feb 15, 2018

The branch

@PeterSurda
Copy link
Member

@g1itch I sent you an email, did you get it?

@g1itch
Copy link
Collaborator

g1itch commented Feb 20, 2018

Yes, I'll try to grab some words and give a proper answer.

@g1itch
Copy link
Collaborator

g1itch commented Feb 22, 2018

Huh, it's almost done. I guess it will require a massive beta-test (or alpha?). I've used QtPy, so it will be compatible with PyQt4 and pyside.

g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 4, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 5, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 15, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 15, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 16, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 16, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 16, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 16, 2018
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 16, 2018
@NourEddineX
Copy link
Contributor

Hello , please note that PyQt4 has been dropped from Manjaro, one of major desktop linux distros

g1itch added a commit to g1itch/PyBitmessage that referenced this issue Jan 22, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Jan 25, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Feb 4, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Feb 12, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Feb 24, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Mar 3, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Apr 29, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue May 2, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue May 8, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue May 8, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue May 15, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue May 15, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Jun 9, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Jun 14, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Jun 18, 2021
@g1itch g1itch self-assigned this Jun 29, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Jul 4, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Jul 13, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Aug 19, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Aug 20, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Aug 26, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Aug 27, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Aug 27, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Aug 30, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Sep 1, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Oct 7, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 6, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Nov 26, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Dec 13, 2021
g1itch added a commit to g1itch/PyBitmessage that referenced this issue Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

No branches or pull requests

8 participants