fixed CQ for bitmessageqt.languagebox module #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1itch
reviewed
Jun 3, 2020
src/bitmessageqt/languagebox.py
Outdated
| self.clear() | ||
| localesPath = os.path.join(paths.codePath(), 'translations') | ||
| self.addItem(QtGui.QApplication.translate( | ||
| "settingsDialog", "System Settings", "system"), "system") | ||
| self.setCurrentIndex(0) | ||
| self.setInsertPolicy(QtGui.QComboBox.InsertAlphabetically) | ||
| for translationFile in sorted( | ||
| glob.glob(os.path.join(localesPath, "bitmessage_*.qm")) | ||
| glob.glob(os.path.join(localesPath, "bitmessage_*.qm")) |
There was a problem hiding this comment.
@g1itch pylint complains for it
C: 33, 0: Wrong hanging indentation before block (add 4 spaces).
glob.glob(os.path.join(localesPath, "bitmessage_*.qm"))
^ | (bad-continuation)
what possible I can do with this ?
There was a problem hiding this comment.
It's a bug:
psf/black#48
pylint-dev/pylint#289
There was a problem hiding this comment.
I tired to point all of you to the same bugs and PEP8 sections...
There was a problem hiding this comment.
@g1itch so for now I should undo this ?
There was a problem hiding this comment.
undo change and override pylint
g1itch
reviewed
Jun 3, 2020
g1itch
reviewed
Jun 3, 2020
src/bitmessageqt/languagebox.py
Outdated
| @@ -8,24 +10,27 @@ | |||
|
|
|||
|
|
|||
| class LanguageBox(QtGui.QComboBox): | |||
| """LanguageBox class for QT UI""" | |||
There was a problem hiding this comment.
@g1itch sorry for that give me a minute,I am fixing it right now.
g1itch
reviewed
Jun 3, 2020
PeterSurda
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint fixes for bitmessageqt.languagebox module