FIFO Success Test #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added unit test to validate the success criteria of FIFO Select coin logic - added a generator function to create FIFO output Groups from vectors
delcin-raj
reviewed
Aug 28, 2024
| @@ -315,6 +315,10 @@ pub fn select_coin_fifo( | |||
|
|
|||
| for (index, inputs) in sorted_inputs { | |||
| estimated_fees = calculate_fee(accumulated_weight, options.target_feerate); | |||
| let outter = (options.target_value | |||
delcin-raj
requested changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Theoretically, a coin select algorithm should be selected as the best candidate by the select_coin function, if it produced the minimum amount of waste. Verification of the expected behaviour is needed with the help a crafted inputs that are biased towards a specific coin_select algorithm.
Changes
test_select_coin_fifo_successfulunit test function to validate the correcteness of FIFO algorithmScope Of Change
This is a semi critical change because the test is expected to acts a verifier of the coin-select and FIFO logic, such test logic should therefore be correct.