Replace hyperx with minimal, vendored Content-Range parsing #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
hyperx
(https://github.com/dekellum/hyperx) dependency, because that dependencies takes the unusual approach of putting strict upper bounds on dependencies (not just restricting to semver-compatible versions, as Cargo does by default), and seems to be relatively unmaintained: a fix dekellum/hyperx#40 for that issue hasn't been merged for a while.This dependency is only used to parse the
Content-Range
header value. This header is very simple, and thus it's easy to implement what's required directly ingha-toolkit
.Similar to #6, removing this dependency makes integrating
gha-toolkit
into other projects much easier. For example, in pantsbuild/pants#17840, I had use Cargo's[patch.crates-io]
directive to refer to dekellum/hyperx#40, or else cargo couldn't find a valid set of dependencies (that is, I literally couldn't addgha-toolkit
as a dependency due tohyperx
).This also positively improves the transitive dependencies of
gha-toolkit
too:language-tags
andmatches
are no longer required (i.e. the dependency tree/compile times is smaller)bytes
,form_urlencoded
,idna
,percent-encoding
,url
can use newer versions, sincehyperx
's upper bounds have disappeared