Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Minor) Update root pubkey in test #51

Closed
mikedotexe opened this issue May 23, 2024 · 2 comments
Closed

(Minor) Update root pubkey in test #51

mikedotexe opened this issue May 23, 2024 · 2 comments

Comments

@mikedotexe
Copy link

Looks like the root key was changed to:

secp256k1:4NfTiv3UsGahebgTaHyD9vF8KYKMBnfd6kh94mK6xv8fGBiJB8TBtFMP5WWXz6B89Ac1fbpzPwAvoyQebemHFwx3

Looks like this could get updated if you think it's important:

https://github.com/Mintbase/near-ca/blob/c674abfe70dcd6a95479689536ac4bf4c9ac9173/tests/unit/utils.kdf.test.ts#L8

I found that updated on this page:

https://docs.near.org/build/chain-abstraction/chain-signatures#1-deriving-the-foreign-address

@bh2smith
Copy link
Collaborator

Hey, thanks for letting me know about the change of root key. I think that for the purpose of our unit tests this key doesn't really matter. If we change the key, then we will also have to change all the expected results. Perhaps it is best to just add a comment inline to the docs containing the actual root key.

@bh2smith
Copy link
Collaborator

bh2smith commented Aug 5, 2024

This was updated during test corrections for the MPC contract update:
#65

In fact this issue actually helped during debugging.
Thanks @mikedotexe for reporting.

@bh2smith bh2smith closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants