-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MPC Contract Signature Arguments #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
force-pushed
the
hotfix/new-sign-args
branch
from
June 12, 2024 21:18
61c5ccf
to
b934bfb
Compare
bh2smith
force-pushed
the
hotfix/new-sign-args
branch
from
July 2, 2024 12:01
b934bfb
to
6f6e5a4
Compare
This won't work with the V5 contract or the mainnet contract. Here's the full changelog for the v5 contract. |
bh2smith
force-pushed
the
hotfix/new-sign-args
branch
from
July 23, 2024 16:23
543f6b7
to
a3c90d1
Compare
Well that was a nightmare. BUT I GOT IT! |
bh2smith
requested review from
microchipgnu and
tifrel
and removed request for
microchipgnu
July 24, 2024 12:22
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Near MPC Contract was recently updated (the whole interface has been modified) - specifically the arguments for the sign method: See here near/mpc#613
This contract is deployed to: https://testnet.nearblocks.io/address/v1.signer-prod.testnet
In this transaction: https://testnet.nearblocks.io/txns/E2fQfcdqPARCnok7RFAJ6WXur3SDKEB7ESgYiH5zHfBT
This PR
Note that the recovery ID is now returned with the MPC Signature, so we can remove A LOT of fluff related to signature "Recovery". There may still be more fluff that can be removed (or perhaps some may need to be reintroduced). Unfortunately the availability of the signing service is not stable enough to test everything. However, we have seen a successful request already: https://sepolia.etherscan.io/tx/0x1adfbaa3151ebdd69b790da41e719eaa039861bd7f56e34fd9f280bded63f535
This change is "breaking" in the sense that the MPC contract interface no longer accets the old Near Tx Payload. This means that the project will no longer work for users pointing at the v2.multichain-mpc.testnet as it does not appear to have been updated along with v1.signer-prod.testnet which we use by default here.