feat(MBI): Release MBI to develop #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ramona Nájera Fuentes <RamonaNF@users.noreply.github.com>
MBI Baseline
Feat/rf06 send task email
Feat/Expenses/RF32: Endpoint for expenseReport data by id
Feat/rf37 consultar expenses
fix(RF32): Add accounting role to access all expense reports
…report RF29: Create Expense Report
…date the relation
This commit updates the sendProjectStatusUpdateNotification function in the NotificationService. It now includes a validation check to ensure that the sender is not from the same department as the recipient. If the sender is from the same department, the function returns a message indicating that an email cannot be sent to the same department. This helps prevent unnecessary notifications within the same department. The validation is performed by the new validateSenderDepartment function, which retrieves the employee and department information using the EmployeeRepository and DepartmentRepository respectively. If the validation fails, the function returns the appropriate error message. This enhancement improves the functionality and reliability of the sendProjectStatusUpdateNotification function.
…tre-areas Feat/rf31 notificacion entre areas
…cessfully deleted, and an unnecessary line was deleted
…deViatico Feat/rf35 eliminar reporte de viatico
…iatico Feat/rf29 crear reporte viatico
…/Zeitgeist-Backend into feat/RF13-EliminarProyecto
feat/RF13-EliminarProyecto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBI: Release to staging
[MBI]: Se liberan los cambios de MBI a la rama develop.
Descripción
Se agregaron los siguientes requisitos funcionales.
Cambios realizados
Pruebas
Se construyeron las pruebas unitarias necesarias para comprobar el correcto funcionamiento de todos los requerimientos.
Screen de pruebas y/o notas
N/A