Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NPS & Polyphony stats #76

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Add NPS & Polyphony stats #76

merged 5 commits into from
Nov 24, 2024

Conversation

MyBlackMIDIScore
Copy link
Member

@MyBlackMIDIScore MyBlackMIDIScore commented Oct 17, 2024

Haven't figured out how to do polyphony for cake yet

Also I am not 100% sure about the NPS implementation, if there is a better way to do it lmk

src/gui/window/stats.rs Outdated Show resolved Hide resolved
src/gui/window/stats.rs Outdated Show resolved Hide resolved
src/gui/window/scene/note_list_system/mod.rs Show resolved Hide resolved
src/gui/window/fps.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@arduano arduano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this

@MyBlackMIDIScore
Copy link
Member Author

Oh oops, I forgot about this too

Btw should we release 1.0 and leave #74 and #75 for later or should we fix those first?

@MyBlackMIDIScore MyBlackMIDIScore merged commit 33ecdec into master Nov 24, 2024
1 check passed
@MyBlackMIDIScore MyBlackMIDIScore deleted the stats branch November 24, 2024 16:53
@arduano
Copy link
Collaborator

arduano commented Nov 24, 2024

Yeah 1.0 now is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants