Replaced SKY UX error component with iframe (blackbaud#485)

Blackbaud-MikitaYankouski · May 3, 2019 · 534742a · 534742a
1 parent a8382cb
commit 534742a
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 10 deletions.
diff --git a/lib/sky-pages-route-generator.js b/lib/sky-pages-route-generator.js
@@ -125,16 +125,24 @@ function generateRoutes(skyAppConfig) {
       `@Component({ template: '<router-outlet></router-outlet>' }) export class RootComponent {}`
   });
 
+  const notFoundComponent = {
+    componentName: 'NotFoundComponent',
+    routePath: ['**'],
+    routeParams: []
+  };
+
   if (skyAppConfig.runtime.handle404) {
-    const err = `<sky-error errorType="notfound"></sky-error>`;
-    entities.push({
-      componentName: 'NotFoundComponent',
-      componentDefinition: `@Component({ template: '${err}' }) export class NotFoundComponent { }`,
-      routePath: ['**'],
-      routeParams: []
-    });
+    const err = [
+      '<iframe src="https://host.nxt.blackbaud.com/errors/notfound"',
+      'style="border:0;height:100vh;width:100%;"',
+      `[title]="'skyux_builder_page_not_found_iframe_title' | skyAppResources"></iframe>`
+    ].join(' ');
+    notFoundComponent.componentDefinition =
+      `@Component({ template: \`${err}\` }) export class NotFoundComponent { }`;
   }
 
+  entities.push(notFoundComponent);
+
   return entities;
 }
 

diff --git a/src/assets/locales/resources_en_US.json b/src/assets/locales/resources_en_US.json
@@ -0,0 +1,6 @@
+{
+  "skyux_builder_page_not_found_iframe_title": {
+    "message": "Page not found",
+    "_description": "A string value to represent the Page Not Found iframe title attribute."
+  }
+}
diff --git a/test/sky-pages-module-generator.spec.js b/test/sky-pages-module-generator.spec.js
@@ -127,7 +127,9 @@ describe('SKY UX Builder module generator', () => {
       skyux: runtimeUtils.getDefaultSkyux()
     });
     expect(source).toContain('NotFoundComponent');
-    expect(source).not.toContain("template: '<sky-error errorType=\"notfound\"></sky-error>'");
+    expect(source).not.toContain(
+      `template: \`<iframe src="https://host.nxt.blackbaud.com/errors/notfound"`
+    );
   });
 
   it('should handle 404', () => {

diff --git a/test/sky-pages-route-generator.spec.js b/test/sky-pages-route-generator.spec.js
@@ -352,7 +352,8 @@ describe('SKY UX Builder route generator', () => {
         handle404: true
       }
     });
-    expect(routes.definitions)
-      .toContain("template: '<sky-error errorType=\"notfound\"></sky-error>'");
+    expect(routes.definitions).toContain(
+      `template: \`<iframe src="https://host.nxt.blackbaud.com/errors/notfound"`
+    );
   });
 });