-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A proposal for implementing #124 #162
Conversation
…e keys and returning all keys from local storage
Let me know @chrissainty if anything else is needed! 👍 |
Anything more I can do, @chrissainty ? 😊 |
My apologies for the delay on this @koskila.I've been swamped with work stuff. I'm hoping to look at tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this so far @koskila. I do have a few changes, if that's ok. I've left a few suggested changes. Also, I can't see a synchronous version of the new GetKeys
method, or an async version of the new RemoveItems
method. Could these be added as well please?
The synchronous and asynchronous APIs should be the same.
Co-authored-by: Chris Sainty <chrissainty@users.noreply.github.com>
Co-authored-by: Chris Sainty <chrissainty@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @koskila, I might be missing something as I'm reviewing on my phone but is the ISyncLocalStorageSerive exposing all the new methods? Looks the the new Keys method is missing still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @koskila! great work
This seemed like a simple enough ask - it's essentially just a wrapper for Object.keys(localStorage) and for calling localStorage.clear(key) multiple times, but hey, let's call it a quality-of-life upgrade? 😅