Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Custom Style Wiki and Samples #364

Merged
merged 5 commits into from
Dec 28, 2021

Conversation

aterbo
Copy link
Contributor

@aterbo aterbo commented Nov 28, 2021

Per Issue #361, this PR updates the Wiki to include information on the CSS parameters that are necessary when using a custom class to avoid some of the issues identified (no z-height, misaligned headers, no styling). It also updates the samples to better show the effect of custom styles using CSS. As part of the update of the samples, a more clearly named CSS class is used (my-custom-modal-class vs blazored-prompt-dialog) and removed unused styles in the examples.

@aterbo aterbo changed the title Clarify custom styles Clarify Custom Style Wiki and Samples Nov 28, 2021
@larsk2009
Copy link
Collaborator

Thanks @aterbo, I think this is a great addition! I am not sure if we are updating the docs folder anymore. If we are, can you also have a look at updating that? @chrissainty do we still keep the docs up to date in that folder?

@larsk2009 larsk2009 requested a review from chrissainty December 3, 2021 10:31
@aterbo
Copy link
Contributor Author

aterbo commented Dec 3, 2021

@larsk2009 I'm happy to update the Docs. I missed that the first time around. I'll update the PR when I get a minute.

@chrissainty
Copy link
Member

@aterbo No we're not using the docs folder anymore so don't worry about updating any of that. @larsk2009 maybe we should get that folder removed to avoid confusion in the future.

@larsk2009
Copy link
Collaborator

Yeah should definitely remove it (in a seperate PR offcourse 😉)

@aterbo aterbo mentioned this pull request Dec 4, 2021
@aterbo
Copy link
Contributor Author

aterbo commented Dec 4, 2021

@larsk2009 I went ahead and submitted another PR doing so. I actually did a bit of searching in the repo, and it looks like that issue has come up in the past, but always as a side conversation and never as a direct issue. Looks like it just slipped through a few times. Hope the other PR can resolve it. Deleting documentation files is easier than adding them :)

@larsk2009
Copy link
Collaborator

Great @aterbo!

@aterbo aterbo mentioned this pull request Dec 23, 2021
@chrissainty
Copy link
Member

Thanks for this @aterbo. Doc updates are always appreciated.

@chrissainty chrissainty merged commit 1f4a33d into Blazored:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants