Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly passes timeout per toast instance #202

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

Cvijo
Copy link
Contributor

@Cvijo Cvijo commented Feb 14, 2023

This should fix bug when setting Timeout on the toast instance service.

BuildToastSettings was taking Timeout from the Global instance

Copy link
Member

@chrissainty chrissainty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @Cvijo

@chrissainty
Copy link
Member

@Cvijo I've just seen your latest push. Is that for the bug fix or for the pause while hovering? If it's the latter can you revert it. This PR should only deal with the bug fix for timeout.

@Cvijo
Copy link
Contributor Author

Cvijo commented Feb 14, 2023

i don't know how to revert :) :) first time i am pulling requests :)

This reverts commit e27f67d.
@Cvijo
Copy link
Contributor Author

Cvijo commented Feb 14, 2023

this should be ok now?

@chrissainty chrissainty merged commit 96531f1 into Blazored:main Feb 15, 2023
@chrissainty chrissainty added the Bug Something isn't working label Feb 23, 2023
@chrissainty chrissainty changed the title Fixes Blazored/Toast#195 Fix: Correctly passes timeout per toast instance Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants