Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new DisableTimeout setting #206

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Adds new DisableTimeout setting #206

merged 2 commits into from
Feb 21, 2023

Conversation

chrissainty
Copy link
Member

Resolves #193

@chrissainty chrissainty added the Feature New feature that will be added to the project label Feb 21, 2023
@Cvijo
Copy link
Contributor

Cvijo commented Feb 21, 2023

hi @chrissainty, I think you will need to add instanceToastSettings.DisableTimeout ??= DisableTimeout; to BuildCustomToastSetting too, i think it would be null if they don't set it on instance settings and this line Settings.DisableTimeout!.Value would throw error i think

    private ToastSettings BuildCustomToastSettings(Action<ToastSettings>? settings)
    {
        var instanceToastSettings = new ToastSettings();
        settings?.Invoke(instanceToastSettings);
        instanceToastSettings.DisableTimeout ??= DisableTimeout; **<-- this line**

        return instanceToastSettings;
    }

@chrissainty
Copy link
Member Author

@Cvijo Great spot!

@chrissainty chrissainty merged commit 8763944 into main Feb 21, 2023
@chrissainty chrissainty deleted the 193-infinite-timeout branch February 21, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature that will be added to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support for infinite timeout
2 participants