Restore Use of Configuration Toast Level-Specific Css Classes #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorchasewhite
force-pushed
the
fix-configuration-classes-applied-to-toasts
branch
from
f280171 to
598f52c
Compare
|
Rebased to incorporate fixes/changes from #226 |
|
Jk, just noticed this line:
|
|
Apologies for the delay getting to this PR, @taylorchasewhite. The changes look good, just needs the latest from |
|
Okay! I'm out at a bar enjoying summer weather at the moment, but I can pull those in when I get back! ☀️🌊🍻 |
|
You enjoy the weather @taylorchasewhite 😎🍻 |
chrissainty
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to close #221 which addresses the loss of respecting various parameters to the
BlazoredToastscomponent like:WarningClassErrorClassSuccessClassWe respect instance specific classes, but appear inadvertently to have removed support for these arguments. This is fixed in this PR. I also did a little bit of refactoring 🤪.