Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRT emulation shader #160

Closed
0x4E69676874466F78 opened this issue Sep 25, 2021 · 10 comments
Closed

CRT emulation shader #160

0x4E69676874466F78 opened this issue Sep 25, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@0x4E69676874466F78
Copy link
Contributor

0x4E69676874466F78 commented Sep 25, 2021

Thanks for the good app.
Many old games are scary on LCD. I would like to run any old games with CRT shader.
For example:
https://github.com/mamedev/mame/tree/master/hlsl (MAME HLSL CRT shader)
https://github.com/Matsilagi/RSRetroArch (CRT and etc shader collection, ported for ReShade and ShaderToy)

@Blinue Blinue added the enhancement New feature or request label Sep 26, 2021
@Blinue
Copy link
Owner

Blinue commented Sep 26, 2021

I'll port them after v0.7 is released.

@0x4E69676874466F78
Copy link
Contributor Author

@Blinue

I'll port them after v0.7 is released.

Thank you very much!

@Blinue Blinue mentioned this issue Nov 22, 2021
10 tasks
@Blinue
Copy link
Owner

Blinue commented Dec 23, 2021

I've ported some CRT shaders, including CRT-Easymode, CRT-Geom, CRT-Hyllian, CRT-Lottes and GTU, I think this is enough for most people

crt-royale is a nice shader too, but it doesn't fit magpie

@0x4E69676874466F78
Copy link
Contributor Author

@Blinue thanks a lot!
Soon I will try a new shaders.

crt-royale is a nice shader too, but it doesn't fit magpie

What's wrong there?

@Blinue
Copy link
Owner

Blinue commented Dec 28, 2021

crt-royale has high requirements on the size of the input image. It is more suitable to be integrated in a simulator than as a general-purpose post-processing stage.

@0x4E69676874466F78
Copy link
Contributor Author

Thanks for the answer.

@Blinue Blinue closed this as completed Dec 28, 2021
@0x4E69676874466F78
Copy link
Contributor Author

0x4E69676874466F78 commented Jan 5, 2022

Visually more correct settings:

  {
    "name": "CRT-Geom",
    "effects": [
      {
        "effect": "CRT_Geom",
        "scale": [ -1, -1 ],
        "curvature": 0,
        "CRTGamma": 1.5,
        "monitorGamma": 2.2,
        "cornerSize": 0.001,
      }
    ]
  },

I don't know why need to reduce CRTGamma.

Lanczos
magpie-lanczos

CRT-Geom before:
magpie-crtgeom-before

CRT-Geom after:
magpie-crtgeom-after

@0x4E69676874466F78
Copy link
Contributor Author

0x4E69676874466F78 commented Jan 5, 2022

Also need to include in settings all CRT Shaders.
CRT_Hyllian and CRT_Lottes are good.
For this game I liked more CRT_Lottes.
But I will try to make a hybrid with FXAA antialiasing.

  {
    "name": "CRT-Lottes",
    "effects": [
      {
        "effect": "CRT_Lottes",
        "scale": [ -1, -1 ]
      }
    ]
  },
  {
    "name": "CRT-Hyllian",
    "effects": [
      {
        "effect": "CRT_Hyllian",
        "scale": [ -1, -1 ]
      }
    ]
  },
  {
    "name": "CRT-Easymode",
    "effects": [
      {
        "effect": "CRT_Easymode",
        "scale": [ -1, -1 ]
      }
    ]
  },

@Blinue
Copy link
Owner

Blinue commented Jan 5, 2022

Thanks for the test, here is a sample config:
https://gist.github.com/hooke007/818ecc88f18e229bca743b7ae48947ad#file-scalemodels-json-L240

Gist
[Magpie profile] https://github.com/Blinue/Magpie 示例缩放配置 - ScaleModels.json

@0x4E69676874466F78
Copy link
Contributor Author

0x4E69676874466F78 commented Jan 5, 2022

Very nice:

  {"name":"CRT_Lottes+SMAA_High","effects":[
    {"effect":"SMAA_High"},
    {"effect":"CRT_Lottes","scale":[-1,-1],
     "hardScan":-8,"hardPix":-3,"warpX":0.0,"warpY":0.0,
     "maskDark":0.5,"maskLight":1.5,"scaleInLinearGamma":1,"shadowMask":3,"brightBoost":1,
     "hardBloomPix":-1.5,"hardBloomScan":-2,"bloomAmount":0.15,"shape":2},
  ]},

изображение

Thanks again for porting these shaders to Magpie!

Blinue added a commit that referenced this issue Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants