Fix tcp serial ports #1596
Merged
Fix tcp serial ports #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using TCP serial port functionality and found that it would never end up listening on the port
After some digging I've traced it down to this:
Here in
openser(),sernameis passed toopentcp()skipping the "TCP://" parthttps://github.com/BlitterStudio/amiberry/blob/8196671d573c07d45fa90f9d3d55d3e67d4ad959/src/osdep/amiberry_serial.cpp#L338C1-L345C3
opentcp()callsuae_tcp_listen_uri()which expects the protocol to be part of the URI, otherwise it returns withUAE_SOCKET_INVALIDhttps://github.com/BlitterStudio/amiberry/blob/8196671d573c07d45fa90f9d3d55d3e67d4ad959/src/osdep/socket.cpp#L131C1-L137C3
This pull request fixes this issue by passing the full sername through to opentcp