Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block details #214

Merged
merged 13 commits into from
Dec 22, 2023
Merged

Block details #214

merged 13 commits into from
Dec 22, 2023

Conversation

PabloCastellano
Copy link
Member

@PabloCastellano PabloCastellano commented Nov 28, 2023 •
edited
Loading

Fixes #133

Changes:

  • Do not format Block and Slot number with commas, as in other block explorers. It also makes it easier to copy-paste.
  • Blob Gas Price now is shown in ether and gwei for easier conversions
  • Removed 'Total' from metric names
  • Blob Gas Used now shows the percentage of blob space used and target blob gas (reminder: maximum blobs per block is 6, while target is 3, similar to how the gas fee work)
  • Show number of blobs next to Blob Size
  • Show Blob Gas Limit

BEFORE THIS PR:

image

AFTER THIS PR:

image

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 4:54pm
blobscan-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 4:54pm

0xGabi
0xGabi requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement 🙌

apps/web/src/pages/block/[id].tsx Outdated Show resolved Hide resolved
apps/web/src/pages/block/[id].tsx Show resolved Hide resolved
apps/web/src/pages/block/[id].tsx Outdated Show resolved Hide resolved
apps/web/src/pages/block/[id].tsx Outdated Show resolved Hide resolved
apps/web/src/utils/ethereum.ts Outdated Show resolved Hide resolved
apps/web/src/pages/block/[id].tsx Show resolved Hide resolved
@PabloCastellano
fix: display Gwei instead of gwei
b9d5352
@PabloCastellano
address comments
da86587 
- Use constants
- Remove comma from block number in tx page
PJColombo
PJColombo approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@PJColombo PJColombo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍!

Added the following:

  1. Added the blob gas visual percentage bar.
  2. Added some extra code refactorizations.
  3. Resolved the remaining review conversations.

@PJColombo PJColombo merged commit 7cf440e into next Dec 22, 2023
6 of 7 checks passed
@PJColombo PJColombo deleted the block-detail branch December 22, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi requested changes

@PJColombo PJColombo PJColombo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New metric to show % of blobspace used
3 participants
@PabloCastellano @0xGabi @PJColombo