Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create Rollup filter & FilterPanel #496

Merged
merged 35 commits into from
Aug 31, 2024
Merged

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Aug 8, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

  • Add to Dropdown option a prefix prop to be used as slot -> This scenario passes a RollupIcon
  • Create FilterPanel to be used as a base for more filters
  • Add a rollup dropdown to be able to filter in the blobs, blocks, and transactions view tables by rollup
  • Fix pages number in <PaginatedTable />

Related Issue

Screenshots

image

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 27c687e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@blobscan/rollups Minor
@blobscan/web Minor
@blobscan/db Minor
@blobscan/api Patch
@blobscan/blob-propagation-jobs-cli Patch
@blobscan/stats-aggregation-cli Patch
@blobscan/auth Patch
@blobscan/blob-propagator Patch
@blobscan/blob-storage-manager Patch
@blobscan/syncers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:19pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 1:19pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 1:19pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 1:19pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 1:19pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 1:19pm

@xFJA xFJA changed the title Create rollup filter feat: create Rollup filter & FilterPanel Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 271.25 KB (🟡 +25.63 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 352.29 KB 623.54 KB 178.15% (🟢 -4.86%)
/address/[address] 27.26 KB 298.51 KB 85.29% (🟢 -4.71%)
/blob/[hash] 26.35 KB 297.6 KB 85.03% (🟢 -4.60%)
/blobs 24.84 KB 296.09 KB 84.60% (🟢 -2.28%)
/block/[id] 12.61 KB 283.86 KB 81.10% (🟢 -4.64%)
/blocks 22.57 KB 293.82 KB 83.95% (🟢 -2.28%)
/stats/blob 336.48 KB 607.74 KB 173.64% (🟢 -4.80%)
/stats/block 337.51 KB 608.76 KB 173.93% (🟢 -4.79%)
/stats/tx 336.61 KB 607.86 KB 173.68% (🟢 -4.80%)
/tx/[hash] 14.05 KB 285.3 KB 81.52% (🟡 +0.22%)
/txs 22.05 KB 293.3 KB 83.80% (🟢 -4.30%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I left a few change requests.

I also think it would be better to trigger a redirection to a route with filter query parameters based on the configured filters, rather than re-executing the TRPC fetch call.

The "Filter" button would behave as a link with all the filter query params set

This approach allows the user to share the url with specific filters and maintains consistency with the rest of the routing in the app.

apps/web/src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
apps/web/src/components/PaginatedTable/PaginatedTable.tsx Outdated Show resolved Hide resolved
apps/web/src/components/RollupIcon.tsx Outdated Show resolved Hide resolved
.changeset/smooth-trains-fly.md Outdated Show resolved Hide resolved
@PabloCastellano
Copy link
Member

I also think it would be better to trigger a redirection to a route with filter query parameters based on the configured filters, rather than re-executing the TRPC fetch call.

Suggestion: Instead of using the rollup name as a query parameter, let's use the address that sends the blobs. This will serve as an escape hatch to filter out rollups we haven't identified yet.

@PJColombo PJColombo force-pushed the create-rollup-filter branch from 131a4df to 8ff400c Compare August 29, 2024 19:42
@PJColombo PJColombo merged commit 16870e4 into main Aug 31, 2024
8 checks passed
@PJColombo PJColombo deleted the create-rollup-filter branch August 31, 2024 11:57
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rollup filter Add filters to blobs, blocks and transactions pages
4 participants