-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create Rollup
filter & FilterPanel
#496
Conversation
🦋 Changeset detectedLatest commit: 27c687e The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
271.25 KB (🟡 +25.63 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Eleven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/ |
352.29 KB |
623.54 KB | 178.15% (🟢 -4.86%) |
/address/[address] |
27.26 KB |
298.51 KB | 85.29% (🟢 -4.71%) |
/blob/[hash] |
26.35 KB |
297.6 KB | 85.03% (🟢 -4.60%) |
/blobs |
24.84 KB |
296.09 KB | 84.60% (🟢 -2.28%) |
/block/[id] |
12.61 KB |
283.86 KB | 81.10% (🟢 -4.64%) |
/blocks |
22.57 KB |
293.82 KB | 83.95% (🟢 -2.28%) |
/stats/blob |
336.48 KB |
607.74 KB | 173.64% (🟢 -4.80%) |
/stats/block |
337.51 KB |
608.76 KB | 173.93% (🟢 -4.79%) |
/stats/tx |
336.61 KB |
607.86 KB | 173.68% (🟢 -4.80%) |
/tx/[hash] |
14.05 KB |
285.3 KB | 81.52% (🟡 +0.22%) |
/txs |
22.05 KB |
293.3 KB | 83.80% (🟢 -4.30%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
apps/web/src/components/PaginatedTable/components/RollupFilter.tsx
Outdated
Show resolved
Hide resolved
a6e895a
to
920f909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I left a few change requests.
I also think it would be better to trigger a redirection to a route with filter query parameters based on the configured filters, rather than re-executing the TRPC fetch call.
The "Filter" button would behave as a link with all the filter query params set
This approach allows the user to share the url with specific filters and maintains consistency with the rest of the routing in the app.
apps/web/src/components/PaginatedTable/components/RollupFilter.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PaginatedTable/components/FilterPanel.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PaginatedTable/components/FilterPanel.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PaginatedTable/components/FilterPanel.tsx
Outdated
Show resolved
Hide resolved
Suggestion: Instead of using the rollup name as a query parameter, let's use the address that sends the blobs. This will serve as an escape hatch to filter out rollups we haven't identified yet. |
e608a7d
to
a8745ee
Compare
4206256
to
22a01e1
Compare
033315d
to
e3c1446
Compare
29514ea
to
9bd7c35
Compare
131a4df
to
8ff400c
Compare
8ff400c
to
08c976a
Compare
… rollup filter dropdown value
99346ad
to
27c687e
Compare
Checklist
Description
Dropdown
option aprefix
prop to be used asslot
-> This scenario passes aRollupIcon
FilterPanel
to be used as a base for more filtersrollup
dropdown to be able to filter in theblobs
,blocks
, andtransactions
view tables byrollup
<PaginatedTable />
Related Issue
Screenshots