Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ether display overflow on small screens in Transaction details page #656

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Dec 2, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

To avoid the overflow with big values, we can set the display information into column for smaller devices

Related Issue

Closes #638

Screenshots

BEFORE AFTER
image image

@xFJA xFJA self-assigned this Dec 2, 2024
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: a69088c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 10:38am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 10:38am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 10:38am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 10:38am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 10:38am
blobscan-staging ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 10:38am

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (8f4e316) to head (a69088c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   88.76%   87.89%   -0.88%     
==========================================
  Files         159      158       -1     
  Lines       10863    10856       -7     
  Branches     1204     1164      -40     
==========================================
- Hits         9643     9542     -101     
- Misses       1220     1314      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.51 KB (🔴 +86.89 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 332.75 KB 95.07%
/stats 348.26 KB 680.76 KB 194.50%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 354.45 KB 686.95 KB 196.27% (🟢 -4.25%)
/address/[address] 29.89 KB 362.39 KB 103.54% (🟢 -3.95%)
/blob/[hash] 29.67 KB 362.18 KB 103.48% (🟢 -3.65%)
/blobs 80.74 KB 413.25 KB 118.07% (🟡 +13.69%)
/block/[id] 15.06 KB 347.56 KB 99.30% (🟢 -3.94%)
/blocks 78.48 KB 410.98 KB 117.42% (🟡 +13.69%)
/tx/[hash] 17.56 KB 350.07 KB 100.02% (🟡 +1.23%)
/txs 77.9 KB 410.41 KB 117.26% (🟡 +11.66%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Changeset is missing. Once added, feel free to merge this

@xFJA xFJA merged commit 759fc95 into main Dec 3, 2024
13 of 14 checks passed
@xFJA xFJA deleted the fix-tx-details-card-ether-display-overflow branch December 3, 2024 10:44
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix transaction details page overflow in small screens
3 participants