Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle timestamp #664

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Toggle timestamp #664

wants to merge 9 commits into from

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Added button to toggle between relative time and date-time format

Related Issue

Closes #648

Screenshots

image image image

Dark mode:
image
image
image

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: fd2acfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ❌ Failed (Inspect) Dec 7, 2024 4:14pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 4:14pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 4:14pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 4:14pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 4:14pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 4:14pm

Copy link
Contributor

github-actions bot commented Dec 3, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 332.53 KB (🔴 +86.91 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 332.77 KB 95.08%
/stats 348.26 KB 680.79 KB 194.51%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 354.45 KB 686.97 KB 196.28% (🟢 -4.26%)
/address/[address] 29.89 KB 362.41 KB 103.55% (🟢 -3.96%)
/blob/[hash] 29.67 KB 362.2 KB 103.49% (🟢 -3.65%)
/blobs 80.92 KB 413.45 KB 118.13% (🟡 +13.74%)
/block/[id] 15.06 KB 347.58 KB 99.31% (🟢 -3.95%)
/blocks 78.61 KB 411.14 KB 117.47% (🟡 +13.73%)
/tx/[hash] 17.56 KB 350.09 KB 100.02% (🟡 +1.23%)
/txs 78.03 KB 410.55 KB 117.30% (🟡 +11.69%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (759fc95) to head (fd2acfd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files         158      158           
  Lines       10856    10856           
  Branches     1164     1164           
=======================================
  Hits         9542     9542           
  Misses       1314     1314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xFJA xFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In blobs and transactions tables when you click on the toggle the row increases the height:

Screen.Recording.2024-12-04.at.18.15.51.mov

I would increase the row width instead of the row height. What do you think @PJColombo ?

Co-authored-by: Francisco Jiménez <franjimenezaguilera@gmail.com>
Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

Also, there are still some rows that increase in height because the timestamp field breaks into a new line when toggled to the absolute format.

image

Window shifting also occurs when toggling this field on small screens, particularly on 375x667 resolutions. It seems to happen when the tooltip reaches the edge of the viewport.

Screen Recording 2024-12-07 at 11.51.12

.changeset/slimy-fishes-roll.md Outdated Show resolved Hide resolved
.changeset/slimy-fishes-roll.md Outdated Show resolved Hide resolved
apps/web/src/components/TimestampToggle.tsx Outdated Show resolved Hide resolved
luis-herasme and others added 2 commits December 7, 2024 11:01
Co-authored-by: 0xelessar.eth <paulo.colombo@pm.me>
Co-authored-by: 0xelessar.eth <paulo.colombo@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option to Toggle Between Relative Time and Date-Time Format
3 participants