-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(db): fix total amount of unique blobs aggregation #666
Conversation
Previously, the calculation for the total unique blobs failed to account for blobs’ uniqueness relative to previously existing blobs, focusing only on the current aggregation scope. This fix ensures that the aggregation considers uniqueness across the entire dataset
🦋 Changeset detectedLatest commit: 23fe45b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
332.51 KB (🔴 +86.89 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/block_neighbor |
251 B |
332.75 KB | 95.07% |
/stats |
348.26 KB |
680.77 KB | 194.50% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/ |
354.45 KB |
686.95 KB | 196.27% (🟢 -4.25%) |
/address/[address] |
29.89 KB |
362.39 KB | 103.54% (🟢 -3.95%) |
/blob/[hash] |
29.67 KB |
362.18 KB | 103.48% (🟢 -3.64%) |
/blobs |
80.74 KB |
413.25 KB | 118.07% (🟡 +13.69%) |
/block/[id] |
15.06 KB |
347.56 KB | 99.30% (🟢 -3.94%) |
/blocks |
78.48 KB |
410.98 KB | 117.42% (🟡 +13.69%) |
/tx/[hash] |
17.56 KB |
350.07 KB | 100.02% (🟡 +1.23%) |
/txs |
77.9 KB |
410.41 KB | 117.26% (🟡 +11.66%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 158 158
Lines 10853 10859 +6
Branches 1166 1164 -2
=======================================
+ Hits 9539 9545 +6
Misses 1314 1314 ☔ View full report in Codecov by Sentry. |
Checklist
Description
It adds the following:
LEAST()
SQL function considers null to be smaller than any other value.Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):