Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made topolar() more accurate, added fuzztest for Calc_R() #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

made topolar() more accurate, added fuzztest for Calc_R() #29

wants to merge 3 commits into from

Conversation

amsorrytola
Copy link

@amsorrytola amsorrytola commented Mar 30, 2024 •
edited
Loading

use error approximation in expansion of arctan to return more accurate value.

@amsorrytola amsorrytola changed the title made topolar() more accurate made topolar() more accurate, added fuzztest for Calc_R() Mar 30, 2024
blueh4mster
blueh4mster reviewed Apr 13, 2024
View reviewed changes
Copy link
Contributor

@blueh4mster blueh4mster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohammed-talha-ansari Please remove the comments from the testCalc_RFuzz test. Also, please explain what exact algorithm you have used in order to increase the accuracy of toPolar macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueh4mster blueh4mster blueh4mster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amsorrytola @blueh4mster