Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROJECT: Integrate a New C Library into LBTCftCL #140

Closed
4 tasks
shannona opened this issue Jun 14, 2022 · 4 comments
Closed
4 tasks

PROJECT: Integrate a New C Library into LBTCftCL #140

shannona opened this issue Jun 14, 2022 · 4 comments
Labels
intern project This issue is in regards to an internship project. program: lbtcftcl associated with the Learning Bitcoin from the Command Line projects

Comments

@shannona
Copy link
Collaborator

The libbitcoinrpc RPC C library used in Learning Bitcoin from the Command Line has become outdated as discussed here:
BlockchainCommons/Learning-Bitcoin-from-the-Command-Line#561

It's not just that it's old, it's that it no longer compiles correctly without intervention.

So, we need a new C library. Tasks would be:

  • Find a new C library for sending RPC commands to bitcoind
  • Document its setup and basic usage in 16.1
  • Rewrite 16.2 to use the new C library
  • Check chapter 17 to see if there is any use of the old library, and if so update it.

As far as I know the curl library and the jansson library remain OK. Therefore, I expect much of the commentary, as well as the code not directly using the old library, can still be used.

@shannona
Copy link
Collaborator Author

Here's an alternative path for this task: bring the existing library up to date.

I'm agnostic as to whether to follow the original task list (replacing it) or this one (updating it). I think a lot of it depends on whether there's a great alternative RPC Bitcoin library for C; when I originally decided to use this a few years ago, there was not.

@shannona
Copy link
Collaborator Author

Debian 11 is our default OS that we expect people to be using when they're running Learning Bitcoin, so that's where we should be testing. If you need a Debian 11 linode setup, just let me know.

@shikharvashistha
Copy link

shikharvashistha commented Jul 23, 2022

@shannona && @ChristopherA I've created a pull including the fix and change log for the commit gitmarek/libbitcoinrpc#2

@shannona
Copy link
Collaborator Author

shannona commented Oct 4, 2022

Resolved this by repairing old version & having our own copy of it in a repo.

@shannona shannona closed this as completed Oct 4, 2022
@ChristopherA ChristopherA added the program: lbtcftcl associated with the Learning Bitcoin from the Command Line projects label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intern project This issue is in regards to an internship project. program: lbtcftcl associated with the Learning Bitcoin from the Command Line projects
Projects
None yet
Development

No branches or pull requests

3 participants