Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

series of improvements to this library #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

series of improvements to this library #13

wants to merge 5 commits into from

Conversation

lightyear15
Copy link

in short:

  • adding cmake to the project
  • removing const qualifier in return types
  • removing final from main classes
  • UR::UR constructor using std::move
  • general improvements to code ( C-style arrays to std::array, NULL --> nullptr, and such)

@lightyear15
adding cmake to the project
f2649d8 
also adding a github workflow task that compiles, runs tests and
installs the produced artifacts
@lightyear15
removing const qualifier from returned types
ae5fff1 
it practically does not enforce any sort of const-correctness while
polluting the code.
@lightyear15
removing final from main classes
2679a26 
even though syntatically correct, it does make little sense on classes
that reprensent front-end APIs of this library for different reasons.
On one side, as these classes have no virtual methods and no protected member
variables, they and their internal machineries are already shielded
against weird uses.
Secondly, preventing this library's users to use these classes as base class
does not put library authors under any further future obligation of not
deprecating old code, or changing APIs.
@lightyear15
general improvements to code
07e5f99 
replacing C-style arrays with std::array
adding const-qualified autos
removing return types
replacing typedefs with usings
replacing NULL with nullptr
@lightyear15
in UR::UR constructor use std::move
e38c515 
simply more efficient
greenaddress added a commit to Blockstream/esp32_bc-ur that referenced this pull request May 15, 2024
@greenaddress
improvements from BlockchainCommons#13
5a52c67
greenaddress added a commit to Blockstream/esp32_bc-ur that referenced this pull request May 15, 2024
@greenaddress
improvements from BlockchainCommons#13
c936aac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherA ChristopherA Awaiting requested review from ChristopherA ChristopherA is a code owner

@wolfmcnally wolfmcnally Awaiting requested review from wolfmcnally wolfmcnally is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lightyear15