Fixed the ByteWords wordlist alphabetization error. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wolfmcnally
commented
Oct 5, 2020
wolfmcnally
commented
- Updated to latest version of bc-ur, which fixes the ByteWords wordlist alphabetization error. This was a breaking change, so all documentation and examples were updated.
…t alphabetization error. * Updated to latest version of bc-ur, which fixes the [ByteWords wordlist alphabetization error](BlockchainCommons/Research#45). This was a breaking change, so all documentation and examples were updated.
ChristopherA
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Tested ACK: Built on macOS Catalina (10.15.6), using command line tools for Xcode 11.7. Tested via .build.sh builds with no errors, did sudo make install. Did git clean -n -ffdx to test that make distclean did its job. Did not test incremental build method or other platforms. As this fixes a critical bug PR is approved for Master branch and new tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.