Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests in CI #239

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

ErikDeSmedt
Copy link
Collaborator

@ErikDeSmedt ErikDeSmedt commented Aug 23, 2023

Ensure all unit-tests are run on CI.

I have created a new action for this purpose. The action installs rust, protoc and runs all unit-tests defined in the lib folder.

I have also introduced a make check-all which can be used to run all tests locally.

TODO

  • Fix the broken unit-test

The work to run the python tests is tackled in another MR

@ErikDeSmedt ErikDeSmedt force-pushed the erik/exercise_all_tests_in_ci branch 4 times, most recently from 2dc05b2 to a6ab4c7 Compare August 23, 2023 20:45
@ErikDeSmedt ErikDeSmedt changed the title Run unit tests in check-self Run unit tests in CI Aug 23, 2023
@cdecker cdecker force-pushed the erik/exercise_all_tests_in_ci branch from 71aeb50 to dce3617 Compare August 29, 2023 08:37
@cdecker
Copy link
Collaborator

cdecker commented Aug 29, 2023

Rebased on top of #242

@ErikDeSmedt ErikDeSmedt force-pushed the erik/exercise_all_tests_in_ci branch 6 times, most recently from 5e6638b to 6170ddf Compare August 29, 2023 12:54
@cdecker cdecker marked this pull request as draft August 29, 2023 13:10
@ErikDeSmedt ErikDeSmedt force-pushed the erik/exercise_all_tests_in_ci branch 3 times, most recently from 117d754 to a7524ba Compare August 31, 2023 14:06
@ErikDeSmedt ErikDeSmedt marked this pull request as ready for review September 1, 2023 08:01
@cdecker
Copy link
Collaborator

cdecker commented Sep 10, 2023

ACK a7524ba

@cdecker cdecker enabled auto-merge (rebase) September 10, 2023 14:31
@cdecker cdecker force-pushed the erik/exercise_all_tests_in_ci branch from a7524ba to 68d5e34 Compare September 10, 2023 14:31
Create a new github actions which runs cargo-test in the `libs`-folder.

Created a new rule check-all in the `Makefile` than can be used to run
both integration and unit tests
@cdecker cdecker force-pushed the erik/exercise_all_tests_in_ci branch from 68d5e34 to 0396374 Compare September 11, 2023 12:35
@cdecker cdecker merged commit 41415a4 into Blockstream:main Sep 11, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants