Upgrade cln-* crates #472
Merged
Upgrade cln-* crates #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to upgrade cln_rpc and cln_grpc as they contain the senpay parameter `payment_metadata` that is needed for future applications. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
nepet
force-pushed
the
2426-upgrade-cln-rpc-and-grpc
branch
from
625aa6c
to
ca97558
Compare
cdecker
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to upgrade the
cln-*crates to the latest version ascln-rpc 0.1.9adds the fieldpayment_metadatato thesendpayrpc method.This enables a bunch of new methods on
gl-pluginas well as notifications.Some grpc methods are left unimplemented as they are experimental or do not make sense in the context of a greenlight node with a detached signer.
Please check if we should disable any other methods or implement some of the methods that I disabled for now.