Fix build errors #44
Closed
Fix build errors #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oof :( we should really stop exporting those macros (or give them their own crate). |
Contributor
|
Is there something we can do help move this forward? I have little experience with ASAN unfortunately. This breaking change is creeping into downstream libraries :( |
thomaseizinger
added a commit
to comit-network/maia
that referenced
this pull request
Feb 15, 2022
thomaseizinger
added a commit
to comit-network/maia
that referenced
this pull request
Feb 15, 2022
thomaseizinger
added a commit
to comit-network/maia
that referenced
this pull request
Feb 15, 2022
Member
Author
|
@thomaseizinger, I was unaware of CI failing. Please feel free to take over this PR/open a new one. I have no experience with ASAN |
The upstream impl_array_newtype now implements a core::hash::Hash. This caused a breaking changed here :( despite it being a minor release.
sanket1729
force-pushed
the
fix_build_errors
branch
from
de75c01 to
713f4fe
Compare
Member
Author
|
Oops, I am sorry. I misread your comment. I think we will have to wait for @apoelstra to look at ASAN fixes. Unfortunately, this would have to wait a while till we have a full rust-bitcoin release cycle |
Contributor
|
Closing in favor of #46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream impl_array_newtype now implements a
core::hash::Hash. Thiscaused a breaking changed here :( despite it being a minor release.