Add failure case to secp256k1_generator_generate_interal #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of shallue_van_de_woestijne currently returns an off-curve point when given a value of t. While this is cryptographically impossible to occur, none-the-less we should fail in this case rather than simply return a garbage value.
Contributor
Author
|
This fixes issue #279 using method (B) by having No however this "fix" still results in computations proceeding with off-curve points, which is somewhere between "strongly discouraged" and "a violation of the preconditions of the secp256k1 operations". For an alternative solution see #284. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
Merged alternative fix #286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of shallue_van_de_woestijne currently returns an off-curve point when given a value of t.
While this is cryptographically impossible to occur, none-the-less we should fail in this case rather than simply return a garbage value.