Add witness module #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncomputable
force-pushed
the
2024-10-witness-module
branch
2 times, most recently
from
81aef08
to
ad4b247
Compare
|
Ok, wow, the fuzzer found a bug |
|
Neat! Concept ACK. Though I imagine in the future this will become a weird corner of the language that is only really used by the web IDE. |
|
I moved most changes to #94. The fuzzer bug has to do with the witness module, which kind of lives inside the parse tree and kind of doesn't. |
We introduce a witness module that can be put anywhere inside the source
file. Like in Rust, there can be at most one module of the same name.
mod witness {
const Alice: Signature = 0xabde...;
const Bob: Signature = 0x1234...;
}
The witness module is optional and witness data can still be provided
via JSON. The Simfony program parser ignores any witness modules. A
separate parser parses the witness modules.
Most lines of this commit are boilerplate that the witness module parser
introduces.
uncomputable
force-pushed
the
2024-10-witness-module
branch
from
ad4b247
to
c674d83
Compare
Use fmt::Display to print WitnessValues as a witness module. This can be parsed via ParseFromStr back into WitnessValues. Rename parse_witness_rtt to parse_witness_json_rtt to disambiguate the it from new the target parse_witness_module_rtt. Run cargo fmt inside the `fuzz` crate.
uncomputable
force-pushed
the
2024-10-witness-module
branch
from
c674d83
to
e3ed903
Compare
|
I fixed the fuzzer. Writing witness data directly into the program is a huge feature for the IDE, but I agree that it feels kind of weird. Keeping the program parser separate from the witness parser will allow us to remove the feature if we no longer need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make witness JSON parsing via serde optional. Introduce witness modules as an alternative way to provide witness data. Witness modules are written directly inside the Simfony source code.