More integration #98
Merged
More integration #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new scribe and resolve a long outstanding FIXME.
|
CI failure is real. |
Make crate::witness private, since crate::witness::WitnessValues is already exported. This will break some of my existing code.
common/test.rs: The TestCase struct holds all the data that is necessary to run an integration test. Test cases can be constructed via a builder pattern. At the moment, there is a runtime error if necessary data is missing. This could be changed in the future via marker types, but for simplicity sake we don't do so in this commit. common/util.rs: Functions for computing Simfony witness data. At the moment, we use insecure 32-bit secure keys inside our Simfony programs. We will upgrade to secure keys once we are able to parameterize values such as public keys that are used inside Simfony programs. spend_utxos.rs: The actual integration tests, which are executed in three phases: 1) All tests create a UTXO 2) Enough blocks are mined so the lock time of each test is satisfied 3) All tests try to spend their UTXO This pattern is possible thanks to the monotonicity of time locks, meaning that if a time lock is satisfied at a certain block height, it will remain satisfied in future blocks.
Witness data is dynamically generated, based on sighashes. We no longer need to parse witness JSON files.
uncomputable
force-pushed
the
2024-10-more-integration
branch
from
723c945
to
b432de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the existing harness for integration tests. Write tests for all programs that currently run on Elements. The other programs require more pruning than rust-simplicity currently does.