ci: fixes for newer C compilers, and Haskell build #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should split the QuickCheck stuff out into a separate PR, because I'm worried about the changes to the C code. The change looks like it would introduce a null byte at the end of the arrays, which seems wrong. I mean, it does work, but it would be better for valgrind testing if we don't have nulls. I would like to find an alternative. At the very least we can (and maybe should) just initialize a char array here. |
Fixes the the new warning/error for Wunterminated-string-initialization
|
I'm ashamed to say this now since I literally just told you to split up this PR. However I now think that to make both CI happy and @apoelstra's CI happy we should reopen this PR and update it with what you have done. |
|
Sure will do |
delta1
force-pushed
the
ci/string-init-quickcheck
branch
from
bfe0f64 to
17e3376
Compare
roconnor-blockstream
merged commit ba440a0
into
BlockstreamResearch:master
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some CI failures here: https://github.com/BlockstreamResearch/simplicity/actions/runs/18875552789
This PR does the following:
C build:
Clang 21 and GCC 15 introduce a new warning/error for Wunterminated-string-initialization
Fix this warning by changing the string initializations to array initializations in test.c
Haskell build:
Bump QuickCheck max version