permit all docs to contribute metadata #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documents that failed to parse into markdown were typically ejected from the stream, and were therefore unable to contribute metadata in the form of page titles & document count. now, they contribute metadata and are subsequently ejected from the stream. this scenario previously had strange side-effects with https://stripe.com/docs, where the metadata was scraped from the next available page, and setting random page titles instead of "Stripe Documentation.
|
|
ggordonhall
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documents that failed to parse into markdown were typically ejected from the stream, and were therefore unable to contribute metadata in the form of page titles & document count. now, they contribute metadata and are subsequently ejected from the stream.
this scenario previously had strange side-effects with https://stripe.com/docs, where the metadata was scraped from the next available page, and setting random page titles instead of "Stripe Documentation.