This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
Update answer and studio to gpt4-turbo 24k #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmuller-ml
commented
Nov 30, 2023
rmuller-ml
commented
- We separate the model from agent and answer to have different headrooms
- We don't use the full 128k context window (only 24k)
oppiliappan
suggested changes
Dec 7, 2023
Comment on lines
+60
to
+61
| pub answer_model: model::LLMModel, | ||
| pub agent_model: model::LLMModel, |
There was a problem hiding this comment.
i think its confusing that Agent has, within itself, an agent_model field, can we call this something else? such as decsicion_model or reasoning_model?
There was a problem hiding this comment.
I think agent_model is fine.
The abstraction is: the user queries to get an answer and we have an answer_model used in the tool answer, to get the the correct context to answer the query we start an agent which has its own agent_model
Third opinion @ggordonhall ?
rmuller-ml
commented
Dec 7, 2023
oppiliappan
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.