This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 577
Disable sync repos button when nothing selected #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -105,6 +106,9 @@ const Step2 = ({ handleNext, handleBack }: Props) => { | |||
...prevState, | |||
[STEP_KEY]: repos.filter((r) => r.selected).map((r) => r.ref), | |||
})); | |||
setNextButtonDisabled(!repos.filter((r) => r.selected).length); | |||
} else { | |||
setNextButtonDisabled(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be disabled when there are no repos?
Comment on lines
105
to
106
// console.log(!repos.length); | ||
// console.log(userRepos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
…en in a new browser (#22)
* Update assets on README, logo and gif demo
* Add new `profiler` profile for better performance work * Apply suggestions from code review Co-authored-by: calyptobai <111788964+calyptobai@users.noreply.github.com> Co-authored-by: calyptobai <111788964+calyptobai@users.noreply.github.com>
* add logo and links to readme * add release link * add dummy workflow to get around required checks * update number of langs supported with precise code nav to account for JSX/TSX Co-authored-by: Louis Knight-Webb <louis@bloop.ai>
Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
* reveal a file in finder button * open containing folder instead of a file for linux and windows * add button to full result sidebar
* clicking on code in ref/def popup scroll this line into view * remove initial highlight * add hover effect for code in ref/def tooltip * bugfix: first char was never highlighted * fix tooltip tail position * improve highlight styling * fix typescript errors
* fix release workflow * add ignore paths to dummy workflow Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
* More accurate reporting of searchability * Better delete & rollback logic Co-authored-by: Gabriel Gordon-Hall <ggordonhall@gmail.com>
* WIP * Refactor app navigation, use custom hook with virtual navigation, refactor search page, add full view page * Cleanup, fix merge conflicts * Add lang filters on repo view page * Fix naviagtion issues * Fix repository page flash on navigation * Fix gh navigation * Fix ts errors * Fix query building for navigation
* add Manage repos button to homescreen * fix breadcrumbs too short * show only Readme.md in repo overview * default to letting use choose which GitHub repos to sync * add remove repo button * allow choosing folder every time local repos are added * case-insensitive Readme.md search
anastasiya1155
approved these changes
Dec 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.