Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC window position setting #44

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

POC window position setting #44

wants to merge 1 commit into from

Conversation

zbee
Copy link

@zbee zbee commented Nov 22, 2023

This is a Proof of Concept for a set window position setting addition. For one, it's a nice setting to have an exact position the window will always show at, but the focus was a setting that would result in the nearby players window not moving when the /xldev menu is shown, which this achieves.

This is in response to this reply to my feedback.

As this is a POC, I don't actually recommend this be merged alone, or at least not without follow-up, but this does prevent the window from moving when the dev menu is shown and does add a minor feature.
I marked this as allowing edits to my branch in the case that that would be a cleaner way to build upon this.
This could also be a feature without an associated setting, which I think most users may prefer, but I have not gotten into drag events or immediately notice any, which is where I assume you would implement that, so I left that alone.

I also assume that this setting could be moved under a different setting that might make more sense, I did not give a lot of thought to that, and now seeing my image here it could certainly make more sense under other settings.

Here are the settings I added, and showing that the dev menu does not affect them:
showing the new settings, and that the window has not moved after the dev menu was drawn

Changes

  • Added option to settings menu to display the window at a fixed position.
  • Added option to settings menu for the window position.
  • Added localization strings for the text for those settings.
  • Added conditional position drawing to the nearby player window.
  • Added conditional continuous position drawing to the nearby player window when settings are being modified.

Should be changed, but wasn't

  • I Excluded the Strings.Designer.cs regeneration as it needlessly changed the style of everything.
  • I am unfamiliar with this localization system, I assume that these strings should be added elsewhere as well.
  • I am unfamiliar with Siren GUI, I assume that the Settings I added could be done better.

Added option to settings menu to display the window at a fixed position.
Added option to settings menu for the window position.
Added stings for the text for those settings.
Added conditional position drawing to the nearby player window.
Added conditional continuous position drawing to the nearby player window when settings are being modified.
@zbee
Copy link
Author

zbee commented Nov 22, 2023

I assume it will fail until this is rectified:

I Excluded the Strings.Designer.cs regeneration as my IDE needlessly changed the style of everything in it.

I can commit it if you are unconcerned with its formatting.

@Blooym
Copy link
Owner

Blooym commented Nov 29, 2023

I'll add them properly in Rider when I get the time (and get an OSS rider licence lol)

@Blooym
Copy link
Owner

Blooym commented Mar 2, 2024

To update you on this:
I plan to redo the Settings UI pretty soon since I'm going through all my plugins doing a bit of UI work so I'll try and get this included as apart of that

I still haven't been able to obtain a Rider licence so I might have to manually do the UI strings too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants