Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should there be a function to create an NDIM array initialised with BLOSC2_SPECIAL_NAN? #624

Closed
waynegm opened this issue Jul 8, 2024 · 3 comments
Closed

Should there be a function to create an NDIM array initialised with BLOSC2_SPECIAL_NAN? #624

waynegm opened this issue Jul 8, 2024 · 3 comments
Labels
help wanted

Comments

@waynegm
Copy link
Contributor

waynegm commented Jul 8, 2024

Is there a reason for there being no:
b2nd_nan(b2nd_context_t *ctx, b2nd_array_t **array)
function to create an NDIM array, with BLOSC2_SPECIAL_NAN used as the default value for uninitialized portions of the array?
@FrancescAlted
Copy link
Member

No, that was probably an oversight. Interested in contributing it?

@waynegm
Copy link
Contributor Author

waynegm commented Jul 8, 2024

Sure, I'll fork and send a pull request soon.

waynegm added a commit to waynegm/c-blosc2 that referenced this issue Jul 9, 2024
@waynegm
Add b2nd_nans method Blosc#624
183e8d7
FrancescAlted pushed a commit that referenced this issue Jul 9, 2024
@waynegm @FrancescAlted
Add b2nd_nans method #624
3669c5c
@FrancescAlted
Copy link
Member

Fixed in #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FrancescAlted @waynegm