Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit for water density #159

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix unit for water density #159

merged 1 commit into from
Feb 28, 2024

Conversation

sindrehan
Copy link
Member

Misleading comment in the Protocol led to using the wrong unit when porting to protocol v3.

See BluEye-Robotics/ProtocolDefinitions#139

Misleading comment in the Protocol led to using the wrong unit when
porting to protocol v3.

See BluEye-Robotics/ProtocolDefinitions#139
@sindrehan sindrehan added the bug Something isn't working label Feb 28, 2024
@sindrehan sindrehan requested a review from follesoe February 28, 2024 14:44
@sindrehan sindrehan self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.33%. Comparing base (7977137) to head (4cc9d89).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files          11       11           
  Lines        1211     1211           
=======================================
  Hits          876      876           
  Misses        335      335           
Flag Coverage Δ
macos-latest_3.10 72.33% <100.00%> (ø)
macos-latest_3.11 72.33% <100.00%> (ø)
macos-latest_3.12 72.33% <100.00%> (ø)
macos-latest_3.9 72.31% <100.00%> (ø)
ubuntu-latest_3.10 72.33% <100.00%> (ø)
ubuntu-latest_3.11 72.33% <100.00%> (ø)
ubuntu-latest_3.12 72.33% <100.00%> (ø)
ubuntu-latest_3.9 72.31% <100.00%> (ø)
windows-latest_3.10 72.31% <100.00%> (ø)
windows-latest_3.11 72.31% <100.00%> (ø)
windows-latest_3.12 72.31% <100.00%> (ø)
windows-latest_3.9 72.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sindrehan sindrehan merged commit 0d6808b into master Feb 28, 2024
18 checks passed
@sindrehan sindrehan deleted the fix-water-density-unit branch February 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants