Skip to content

Conversation

rdumusc
Copy link

@rdumusc rdumusc commented Sep 13, 2016

No description provided.

@rdumusc
Copy link
Author

rdumusc commented Sep 13, 2016

retest this please

@eile
Copy link
Contributor

eile commented Sep 13, 2016

What is the motivation/use case for touch point transmission? Can we document this, and how it interacts with higher level events?

@rdumusc
Copy link
Author

rdumusc commented Sep 13, 2016

Right, I will improve documentation. Reasons are:

  • Ability to have more than one touch point (e.g. draw with multiple fingers on a whiteboard)
  • Simplified integration for applications that natively handle touch events, like Qt-based ones (although this is not super visible in the DeflectQt streamer case because of the mouse hack that I had to keep).

void QmlStreamer::Impl::_onPinched( double x_, double y_, QPointF delta )
{
const QPoint point( x_ * width(), y_ * height( ));
QWheelEvent* e = new QWheelEvent( point, delta.y(), Qt::NoButton,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinch should not be translated to wheel I thought?!? QmlStreamer should or can handle gestures/touch points natively, no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, and this is removed in the second commit which introduces the touch points in deflect. I had put it there because it was an independent commit in the beginning, but maybe this was already a mistake. I can amend this commit.

Minor additions to the simplestreamer demo application.
@rdumusc rdumusc force-pushed the pinch branch 2 times, most recently from f43e6a0 to 87f8aff Compare September 14, 2016 12:22
@rdumusc
Copy link
Author

rdumusc commented Sep 14, 2016

Updated, comments addressed.
I was working on an extra commit to move the "touchToMouse" webbrowser hacks into a separate class, but I am going to drop it, it doesn't improves the code the way I had hoped it would.

QmlStreamerImpl.h
)
set(DEFLECTQT_PUBLIC_HEADERS
TouchInjector.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetic order?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

doc/Changelog.md Outdated
- DeflectQt uses a new TouchInjector class for sending touch events to Qt
(moved from Tide).
In addition:
- The *wheel* event has been replaced by a more aptly named *pinch* event.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No true now. Pinch is just new, but wheel still stays.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

DeflectQt: New TouchInjector class for touch events (moved from Tide)
@dnachbaur
Copy link
Contributor

+1

@rdumusc rdumusc merged commit 1b0add5 into BlueBrain:master Sep 16, 2016
@rdumusc rdumusc deleted the pinch branch September 16, 2016 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants