-
Notifications
You must be signed in to change notification settings - Fork 19
Transmit pinch & touch points events to clients [DISCL-386] #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
retest this please |
What is the motivation/use case for touch point transmission? Can we document this, and how it interacts with higher level events? |
Right, I will improve documentation. Reasons are:
|
deflect/qt/QmlStreamerImpl.cpp
Outdated
void QmlStreamer::Impl::_onPinched( double x_, double y_, QPointF delta ) | ||
{ | ||
const QPoint point( x_ * width(), y_ * height( )); | ||
QWheelEvent* e = new QWheelEvent( point, delta.y(), Qt::NoButton, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinch should not be translated to wheel I thought?!? QmlStreamer should or can handle gestures/touch points natively, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, and this is removed in the second commit which introduces the touch points in deflect. I had put it there because it was an independent commit in the beginning, but maybe this was already a mistake. I can amend this commit.
Minor additions to the simplestreamer demo application.
f43e6a0
to
87f8aff
Compare
Updated, comments addressed. |
deflect/qt/CMakeLists.txt
Outdated
QmlStreamerImpl.h | ||
) | ||
set(DEFLECTQT_PUBLIC_HEADERS | ||
TouchInjector.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetic order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
doc/Changelog.md
Outdated
- DeflectQt uses a new TouchInjector class for sending touch events to Qt | ||
(moved from Tide). | ||
In addition: | ||
- The *wheel* event has been replaced by a more aptly named *pinch* event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No true now. Pinch is just new, but wheel still stays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
DeflectQt: New TouchInjector class for touch events (moved from Tide)
+1 |
No description provided.