Added stereo 3D streaming support #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Imo needs a spec.md |
|
Right, should be documented better, working on it. |
eile
reviewed
Feb 6, 2017
doc/StereoStreaming.md
Outdated
|
|
||
| deflect::ImageWrapper rightImage( data, width, height, deflect::RGBA ); | ||
| rightImage.view = deflect::View::RIGHT_EYE; | ||
| deflectStream->send( rightImage ) && deflectStream->finishFrame(); |
There was a problem hiding this comment.
I would expect only one finishFrame finishing all eye passes.
There was a problem hiding this comment.
OK, this could also be supported without side effects I think. I can give it a try.
rdumusc
force-pushed
the
stereo
branch
2 times, most recently
from
1a44d9c
to
8ecdd03
Compare
added 6 commits
February 16, 2017 14:22
Prior to this, the queue of unprocessed segments could grow indefinitely if one of multiple sources of segments stopped sending, or if the application stopped requesting frames (after a JPEG decompression error from a corrupted segment, for instance).
tribal-tec
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.